This repository was archived by the owner on Aug 2, 2023. It is now read-only.
Improve LoadCsv to handle null values when deducing the column types #2916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 15, 2020 10:40
Append a null value to a column when encountering it instead of changing the column type to a StringDataFrameColumn
pgovind
commented
May 15, 2020
| bool rowMoveNext = rowEnumerator.MoveNext(); | ||
| List<object> cachedObjectConversions = new List<object>(); | ||
| while (columnMoveNext && rowMoveNext) | ||
| // Go through row first to make sure there are no data type incompatibilities |
Author
There was a problem hiding this comment.
Might be easier to view this diff with whitespace turned off
gfoidl
reviewed
May 16, 2020
Co-authored-by: Günther Foidl <gue@korporal.at>
Co-authored-by: Günther Foidl <gue@korporal.at>
eerhardt
reviewed
May 18, 2020
eerhardt
reviewed
May 18, 2020
eerhardt
reviewed
May 18, 2020
|
Hello @pgovind! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2915
Instead of falling back to a
StringDataFrameColumn, we now deduce the column type correctly and append anullvalue to whatever the column type becomes.