[release/3.1] Add missing Oracle RIDs #43138
Conversation
Add Runtime Identifiers for missing OL releases. See https://github.com/dotnet/runtime/blob/main/src/libraries/Microsoft.NETCore.Platforms/readme.md#adding-new-rids
|
|
|
@ViktorHofer @ericstj is the comment about signing the license agreement a blocker for approving changes? |
|
Yes, we require signing the CLA to accept contributions. Also this should first be approved in main before backporting to release/3.1. |
| <Parent>linux</Parent> | ||
| <Architectures>x64</Architectures> | ||
| <Versions>7;7.0;7.1;7.2;7.3;7.4;7.5;7.6</Versions> | ||
| <Versions>7;7.0;7.1;7.2;7.3;7.4;7.5;7.6;7.7;7.8;7.9;7.10</Versions> |
There was a problem hiding this comment.
These minor versions were needed back in the early releases of .NET Core, which happened to treat each minor version of RHEL as a separate distinct version. With recent improvements (all of which were implemented by 3.1), that's not needed anymore. .NET will convert version like 7.X to the major version - 7 - internally and save us extra maintenance workload. I don't think there's any reason to add these to the RID graph now.
Red Hat Enterprise Linux 7.9 is the last minor release of RHEL 7.
So we shouldn't be adding 7.10 anyway.
| <Parent>linux</Parent> | ||
| <Architectures>x64;arm64</Architectures> | ||
| <Versions>9</Versions> | ||
| <Versions>9;9.0;9.1</Versions> |
There was a problem hiding this comment.
👎 on adding RHEL 9 minor versions.
| <Parent>rhel</Parent> | ||
| <Architectures>x64</Architectures> | ||
| <Versions>7;7.0;7.1;7.2;7.3;7.4;7.5;7.6</Versions> | ||
| <Versions>7;7.0;7.1;7.2;7.3;7.4;7.5;7.6;7.7;7.8;7.9;7.10</Versions> |
There was a problem hiding this comment.
Have you seen any errors that require adding these specific ol versions? Are there errors building if the parent rhel version of an ol version is missing?
| <RuntimeGroup Include="ol"> | ||
| <Parent>rhel</Parent> | ||
| <Architectures>x64;arm64</Architectures> | ||
| <Versions>9;9.0;9.1</Versions> |
There was a problem hiding this comment.
Are you actually planning to build .NET Core 3.1 on Oracle Linux 9? If so, do you have a plan to deal with OpenSSL 3.0 being the only version available to build against?
|
@Mr-Tao I'm closing this PR since the feedback has not been addressed. Feel free to reopen if you can address it. |
6 participants
This change adds previously missing RIDs for OL releases 7, 8 and 9 and respective RHEL counterparts.