This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Send to helix only when previous steps succeeded #37332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safern
force-pushed
the
FixSendToHelixCondition
branch
4 times, most recently
from
fdf78ac to
63f3662
Compare
Member
Author
No problem. I had a syntax error, if you can take another look good be great 😄 |
Member
|
Lol so much about quality reviews 😂 lgtm |
safern
force-pushed
the
FixSendToHelixCondition
branch
from
79ad42e to
0b0b304
Compare
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed the succeeded evaluation in the send to helix step, so if something previously like restore or build sources failed, it will try to send to helix and it will fail, poluting the build logs.
cc: @ViktorHofer