This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Remove devdocs from System.Runtime.InteropServices code #36669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move public classes/enums to their own file - Use summary instead of devdoc - Misc
AaronRobinsonMSFT
suggested changes
Apr 13, 2019
src/System.Runtime.InteropServices/src/System.Runtime.InteropServices.csproj
Show resolved
Hide resolved
| public class StandardOleMarshalObject : MarshalByRefObject, IMarshal | ||
| { | ||
| private static readonly Guid CLSID_StdMarshal = new Guid("00000017-0000-0000-c000-000000000046"); | ||
| private static readonly Guid StdMarshalClsid = new Guid("00000017-0000-0000-c000-000000000046"); |
Member
There was a problem hiding this comment.
Please don't change class ID variable constant name. The format matches the native format and it helps searching for them. I realize this is not corefx policy, but in this case COM rules win.
Member
There was a problem hiding this comment.
I realize this is not corefx policy
It is corefx naming convention to keep interop related names as is: https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/interop-guidelines.md#naming
Member
There was a problem hiding this comment.
Oh nice. Didn't realize that was spelled out already - Yay.
AaronRobinsonMSFT
approved these changes
Apr 16, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…x#36669) * Cleanup System.Runtime.InteropServices code - Move public classes/enums to their own file - Use summary instead of devdoc - Misc Commit migrated from dotnet/corefx@8d79b61
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.