This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add Utf8String package, reference APIs, and unit tests #35989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
reviewed
Mar 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the ref assembly and unit tests for dotnet/coreclr#23209.
The package is marked non-shipping, just like System.Memory was in the 2.0 timeframe. The package right now is marked as netcoreapp-only, but it would be possible to make a portable implementation that targets downlevel netstandard if desired. (The behaviors would be slightly different than the netcoreapp implementation, but the basic API shape would be identical.)
CI will not pass until the corresponding coreclr change flows through.