Add some unit tests for ASCIIEncoding #35331
Conversation
| } | ||
|
|
||
| [Fact] | ||
| public void GetByteCount_WithSingleCharNonAsciiReplacementFallback_ValidatesAscii() |
There was a problem hiding this comment.
Note to reviewers: This test case currently fails due to a bug in the current implementation of ASCIIEncoding. The actual behavior is that GetByteCount returns 1, but correct behavior would instead be for it to throw ArgumentException.
I'm working on correcting this issue at the same time that the other ASCIIEncoding changes come online.
|
@GrabYourPitchforks what's the status? I don't see update in 2 weeks ... if you're not ready to push it forward, maybe we can close it and reopen when you're ready to give it the time it needs? |
|
@karelz The corresponding coreclr change is held up in PR review. This corefx PR review is signed off; I'm just waiting for the coreclr change to go through first so I don't break the build. |
|
OK, if it is 1-2 weeks away, I am fine keeping it open. Otherwise I would recommend to close it, until there is the right time for it ;) |
|
@GrabYourPitchforks do you have better ETA? |
|
This went in as part of d817d68. |
No runtime changes. Just adds some missing test cases for the
ASCIIEncodingclass.