This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Adding Alpine 3.8 and 3.9 to the RID graph #34789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerhardt
reviewed
Jan 23, 2019
joperezr
force-pushed
the
2.1/FixAlpine
branch
from
ed7881d
to
99d81d1
Compare
|
test failures are not related to my PR. |
stephentoub
approved these changes
Jan 29, 2019
|
@dotnet-bot test this please |
jamshedd
added
Servicing-approved
|
Approved for 2.2.3. |
|
@joperezr @MichaelSimons can we define a RID that covers all Alpine 3.x so we don't have to do this whenever they increment their minor versoin? Also, do we need a matching Nuget change, so that restore provides the correct assets? |
See https://github.com/dotnet/corefx/issues/34316#issuecomment-451485481 for 2 approaches that will fix this better in the future. |
|
Branch not quite open yet |
danmoseley
added
the
* NO MERGE *
wtgodbe
removed
the
* NO MERGE *
|
@jamshedd this is PR in 2.1 branch, not 2.2 -- fixing milestone to 2.1.9 (I assume that's where this fix got). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #34316
Description
Our Docker images have now moved to Alpine 3.8 and with .NET Core 2.1 and 2.2 we claim to support 3.7+. However, our RID graphs only have Alpine 3.7 on the graph, which means that whenever a customer has some special native assets for 3.8 they won't be selected correctly and customers may run into unexpected runtime issues. This change will add both Alpine 3.8 and 3.9 to the RID graph.
Customer Impact
If a customer uses one of our docker images, or is running Alpine 3.8, and want to use special native assets for the new version of the distro they will hit issues as their assets won't be correctly selected. There is a way to work around this for now by setting an environment variable (
DOTNET_RUNTIME_ID=linux-musl-x64) but the proper fix is to add them to the RID graph.Regression?
No
Packaging reviewed?
No
Risk
Low. We have added RIDs many times in the past and it is rarely an issue.
cc: @eerhardt @MichaelSimons