Flow Thread.CurrentPrincipal with ExecutionContext

[MarcoRossignoli]

fixes https://github.com/dotnet/corefx/issues/34489

/cc @jkotas @stephentoub

[benaadams]

Never actually reads from s_asyncLocalPrincipal?

[MarcoRossignoli]

I used similar style of CurrentCulture

corefx/src/Common/src/CoreLib/System/Globalization/CultureInfo.cs

Line 125 in 5e3fe25

s_currentThreadCulture = args.CurrentValue;

[benaadams]

Ah, missed it was being set with the callback

[MarcoRossignoli]

Ohhh first CI with Azure Pipeline for me ❗❗❗ 💥💥💥

[stephentoub]

Ohhh first CI with Azure Pipeline for me

Before you get too excited, note that it's broken :)

[MarcoRossignoli]

test this please

[jkotas]

LGTM otherwise

[jkotas]

CurrentPrincipalContextFlowTest_NotFlow test is failing on Linux.

[MarcoRossignoli]

CurrentPrincipalContextFlowTest_NotFlow test is failing on Linux.

I'll verify...also on Windows.10.Amd64.ClientRS4.Open-x86-Release

[MarcoRossignoli]

test Linux arm64 Release Build please
test corefx-ci please

[MarcoRossignoli]

test Linux arm64 Release Build please

[MarcoRossignoli]

Thank's a lot for the info!Regarding this PR I don't know if needs to have green CI before merge, do we wait Linux CI fix?

[MarcoRossignoli]

@jkotas @stephentoub @danmosemsft PTAL

[safern]

Before you get too excited, note that it's broken :)

😆 -- it is finally not broken anymore 🚀

[MarcoRossignoli]

@safern Will Jenkins removed from CI?If so is there a date?

[stephentoub]

I'll take another look today. Thanks.

[safern]

@safern Will Jenkins removed from CI?If so is there a date?

Yes it will be. There is not a definite date, but should be removed soon as it seems like the azure devops leg is stabilized.

[danmoseley]

@safern Azure CI failed due to "infrastructure issue". Can you remind me how to invoke it again?

[safern]

Yeah. This was because of the DNS outtage.

/AzurePipelines run corefx-ci

However comment triggers are broken due to a github bug apparently. I spoke with azure people and they are aware, will let me know whenever fixed. I’ve retried the attempt in the build UI on the right top corner there are 3 dots, that open a submenu with the retry option.

Also, through comments there is no way to retry as of now, just to RUN ALL again. I’ve filed an issue for retry by comments.

[MarcoRossignoli]

I’ve retried the attempt in the build UI on the right top corner there are 3 dots, that open a submenu with the retry option.

@safern I don't see that menù is only for "MS internals"? (I see "Download the log" or "View queue time.../Add tags"

[stephentoub]

Thanks!

[safern]

@safern I don't see that menù is only for "MS internals"? (I see "Download the log" or "View queue time.../Add tags"

Unfortunately now only MS people can use the retry feature. We've given feedback to be able to retry through comments as that would allow externals to do so. I'll communicate it whenever it is ready 😄

[danmoseley]

Thanks for doing this @MarcoRossignoli , it was a journey 😄

[MarcoRossignoli]

Thanks for doing this @MarcoRossignoli , it was a journey 😄

A pleasure trip as always, I love your attention(maniacal) for code quality. Thank's for the opportunity.