This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix passing null for credentials in SqlConnectionPoolKey #34260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabh500
approved these changes
Dec 27, 2018
| conn3.Open(); | ||
| conn4.Open(); | ||
|
|
||
| SecureString NewPassword = new SecureString(); |
Contributor
|
cc @danmosemsft @afsanehr it would be good to send a PR to master as well and have that merged before the release branch is merged with Shiproom approval. |
leecow
added
Servicing-approved
Member
|
Please wait for branch to open in about 2-3 weeks. Approx 2/12. |
danmoseley
added
the
* NO MERGE *
wtgodbe
removed
the
* NO MERGE *
Contributor
Author
|
@danmosemsft do we need to port this to other branch or is it considered complete? If so, let me know please so I can close the related issue #34205 Thanks! |
Member
|
Is there a reason this PR was specifically opened in release/2.2? Was there also a PR opened in release/2.1? |
Contributor
Author
Member
|
I see, that makes sense. I'll make the necessary changes to ensure this gets shipped with 2.2.3. |
Member
Member
|
That one's good to go, Santi already made the necessary packaging changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34205
Description
Null is passed for credentials when calling SqlConnectionPoolKey ChangePassword method.
Customer Impact
Wrong connection pool gets cleared when calling ChangePassword using a SecureString.
Regression
No, since this code path exists in .Net Framework and credential is mistakenly passed as null.
Risk
High. A password change may cause the connections from wrong pool to be killed causing unexpected application disruption.