[Darc-Update] Update dependencies from build 20181112.25 of https://github.com/dotnet/arcade #33387
Conversation
Auto-Merge StatusThis pull request has not been merged because the subscription with id 'c297d885-0692-40f8-6b97-08d61f281b4c' is waiting on the following merge policies.
|
dotnet-maestro
bot
changed the title
|
@JohnTortugo these failures look related to your signing changes. |
|
Looking |
|
At first look it doesn't seem to be directly related to SignTool because it's a message coming from CSC for a .csproj file. However, I wonder if it's something related to changing this line: https://github.com/dotnet/arcade/blob/c8973913c1299c9e1be5e6f94411d6bfdd9617b2/src/Microsoft.DotNet.Arcade.Sdk/tools/StrongName.targets#L68 because that's the only change related to delay signing that I've done recently. I'm still investigating more on this, tough. |
|
Yes it seems as though setting DelaySign=true triggered this issue but the test project in question https://github.com/dotnet/corefx/blob/master/src/System.Runtime.Loader/tests/System.Runtime.Loader.Noop.Assembly/System.Runtime.Loader.Noop.Assembly.csproj is trying to disable signing. Given that we default StrongNameKeyId to Open in corefx at https://github.com/dotnet/corefx/blob/master/Directory.Build.props#L151 we should probably also set StrongNameKeyId to empty in this test project. |
|
@weshaggard I just came to the same conclusion. I will fix this. |
|
nevermind, you beat me to it |
|
@weshaggard do you also want to add the mapping for the Open key here since it's not present in dotnet/arcade#1302 (comment)? |
|
The netfx leg is failing during test run due to signing issues. Here is an example: |
joperezr
added
the
blocking
|
Marking it as blocking-partner since this is blocking ASP.NET to ingest corefx changes for 3.0 preview |
ericstj
force-pushed
the
darc-master-4c80d68b-45e7-42e5-846a-8aab865db844
branch
from
8ae6bc5 to
6472882
Compare
|
I've made fixes in Arcade, rolled back @weshaggard's workarounds, and updated the version of arcade. 🤞 |
danmoseley
deleted the
darc-master-4c80d68b-45e7-42e5-846a-8aab865db844
branch
…ithub.com/dotnet/arcade (dotnet#33387) * Updating version files * Updating version files * Updating version files * Updating version files * Update dependencies from build 20181115.8 of https://github.com/dotnet/arcade
This change updates the dependencies from https://github.com/dotnet/arcade to the following