Port a DataContractSerialization bug fix from netfx #32205
Conversation
|
@yujayee Do you also have a test for this? |
|
@yujayee Could you add more description for this issue? |
|
@huanwu I don't have much context on this one, it is from DTS bug 489771. |
|
@yujayee what is the plan with this PR? There has not been progress in 2+ weeks. |
|
@yujayee Could you add a test? |
|
@dotnet-bot test OSX x64 Debug Build please |
1 similar comment
|
@dotnet-bot test OSX x64 Debug Build please |
|
There are some build errors from System.Reflection.Tests, which seems not directly related to this code change. Comment out the code change to see if those errors still exist. |
|
I commentted out all the changes I made but the System.Reflection.Tests still failed, which proves the failure is not related to my change. |
|
@dotnet-bot test Linux x64 Release Build |
|
Build fails on OSX (link), a stackoverflow exception was thrown for the new test. Investigating. |
|
@dotnet-bot test NETFX x86 Release Build |
|
@dotnet-bot test Packaging All Configurations x64 Debug Build |
) * Port a dcs fix from netfx, keep the size of isReferenceArray and objectArray in sync and avoid the IndexOutOfRangeException when serializing a huge object graph. * Add a deep linked object serialization test Commit migrated from dotnet/corefx@1887977
This PR is to port a fix from .NET Framework (DTS bug 489771).
Original issue: DataContractSerializer failed with IndexOutOfRange exception while serializing an huge object graph.
Fix: The size of isReferenceArray need be the same as the size of objectArray. The fix is to keep the size of isReferenceArray and objectArray in sync and avoid the IndexOutOfRangeException.