Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Cherry-picking test fix for System.IO.FileSystem from master to release2.2 #31657

Merged
merged 1 commit into from
Aug 10, 2018
Merged

Cherry-picking test fix for System.IO.FileSystem from master to release2.2 #31657

merged 1 commit into from
Aug 10, 2018

Conversation

@maryamariyan
Copy link

@maryamariyan maryamariyan commented Aug 8, 2018 •
edited
Loading

Updating test to assert milisecond granularity for (#30763)

  • non any linux or
  • OSX non-HFS driver formats

Fixes #30742

cc: @danmosemsft @eerhardt @jkotas

@maryamariyan
Updating test to assert milisecond granularity for (dotnet#30763)
98d17ae 
- non any linux or
- OSX non-HFS driver formats

Fixes dotnet#30472
@maryamariyan
Copy link
Author

maryamariyan commented Aug 8, 2018 •
edited
Loading

This PR cherry picks PR #30763 to release/2.2 branch

This test fails on mac.

@maryamariyan maryamariyan self-assigned this Aug 8, 2018
@maryamariyan maryamariyan added the os-mac-os-x OS-X aka Mac OS label Aug 8, 2018
@maryamariyan
Copy link
Author

maryamariyan commented Aug 8, 2018

@dotnet-bot test OSX x64 Debug Build

eerhardt
eerhardt approved these changes Aug 8, 2018
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Anipik
Copy link

Anipik commented Aug 8, 2018

These tests have changed again. The release version of the PR is #31046 The PR is blocked because the servicing 2.1.4 is not opened yet

@maryamariyan
Copy link
Author

maryamariyan commented Aug 9, 2018

Thanks @Anipik, but this PR fixes existing failing tests on this release branch for some mac systems. Also we don't know when the other PR you are linking will end up getting merged

@maryamariyan maryamariyan modified the milestone: 2.1.x Aug 9, 2018
@maryamariyan
Copy link
Author

maryamariyan commented Aug 10, 2018

Shiproom template

Description
Currently 4 System.IO.FileSystem tests fail on this branch. this PR which cherry-picks a PR from master will help fix them.

Customer Impact
no impact. This now helps run all tests successfully for corefx in non HFS mac systems

Regression?
No regression

Risk
Low risk because this change is already in master and also because it is just a test fix to System.IO.FileSystem.

@maryamariyan maryamariyan merged commit ae8c1e9 into dotnet:release/2.2 Aug 10, 2018
@maryamariyan maryamariyan deleted the scout-2.2 branch August 10, 2018 19:28
@karelz karelz added this to the 2.2 milestone Aug 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@eerhardt eerhardt eerhardt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@maryamariyan maryamariyan

Labels

area-System.IO os-mac-os-x OS-X aka Mac OS

Projects

None yet

Milestone

2.2

Development

Successfully merging this pull request may close these issues.

4 participants

@maryamariyan @Anipik @eerhardt @karelz