Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Delete bad test from AsyncValueTaskMethodBuilderTests #23356

Merged
merged 1 commit into from
Aug 17, 2017
Merged

Delete bad test from AsyncValueTaskMethodBuilderTests #23356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 1 addition & 32 deletions src/System.Threading.Tasks.Extensions/tests/AsyncValueTaskMethodBuilderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,36 +82,6 @@ public void Start_InvokesMoveNext()
Assert.Equal(1, invokes);
}

[Theory]
[InlineData(false)]
[InlineData(true)]
public async Task AwaitOnCompleted_InvokesStateMachineMethods(bool awaitUnsafe)
{
AsyncValueTaskMethodBuilder<int> b = ValueTask<int>.CreateAsyncMethodBuilder();
var ignored = b.Task;

var callbackCompleted = new TaskCompletionSource<bool>();
IAsyncStateMachine foundSm = null;
var dsm = new DelegateStateMachine
{
MoveNextDelegate = () => callbackCompleted.SetResult(true),
SetStateMachineDelegate = sm => foundSm = sm
};

TaskAwaiter t = Task.CompletedTask.GetAwaiter();
if (awaitUnsafe)
{
b.AwaitUnsafeOnCompleted(ref t, ref dsm);
}
else
{
b.AwaitOnCompleted(ref t, ref dsm);
}

await callbackCompleted.Task;
Assert.Equal(dsm, foundSm);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you'll need to delete https://github.com/adityamandaleeka/corefx/blob/ae7f6350baa5798459936a00e3b24e0e05356e92/src/System.Threading.Tasks.Extensions/tests/AsyncValueTaskMethodBuilderTests.cs#L187 as well, or else you'll get warnings-as-errors for not using that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, fixed.


[Theory]
[InlineData(1, false)]
[InlineData(2, false)]
Expand Down Expand Up @@ -214,8 +184,7 @@ private struct DelegateStateMachine : IAsyncStateMachine
internal Action MoveNextDelegate;
public void MoveNext() => MoveNextDelegate?.Invoke();

internal Action<IAsyncStateMachine> SetStateMachineDelegate;
public void SetStateMachine(IAsyncStateMachine stateMachine) => SetStateMachineDelegate?.Invoke(stateMachine);
public void SetStateMachine(IAsyncStateMachine stateMachine) { }
}
}
}