This repository was archived by the owner on Jan 23, 2023. It is now read-only.
SqlClientFactory: Override CreateDataAdapter #19682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Override CreateDataAdapter and add tests.
saurabh500
approved these changes
May 11, 2017
stephentoub
reviewed
May 12, 2017
| public void CreateParameter_NotNull() | ||
| { | ||
| Assert.NotNull(SqlClientFactory.Instance.CreateParameter()); | ||
| } |
Member
There was a problem hiding this comment.
Is there nothing more stringent we can check, like the type of the thing that comes back?
Contributor
Author
|
@dotnet-bot test Innerloop Tizen armel Debug Cross Build please |
Member
|
@justinvp thanks for the quick fix! |
Member
|
@justinvp thanks - take a look here if you want to do more ! -- https://github.com/dotnet/corefx/issues/17126 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Override
CreateDataAdapterand add tests.Fixes #19651, #19673
cc: @saurabh500, @corivera
fyi: @RickStrahl, @FransBouma