This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix parsing of regex alternation construct with named options #16609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@dotnet-bot test innerloop windows_nt release build and test (https://github.com/dotnet/corefx/issues/16489) |
Priya91
reviewed
Mar 2, 2017
| [InlineData("(?(?x))", RegexOptions.None, typeof(NullReferenceException))] | ||
| [InlineData("(?(?X))", RegexOptions.None, typeof(NullReferenceException))] | ||
| [InlineData("(?(?e))", RegexOptions.None, typeof(NullReferenceException))] | ||
| [InlineData(" (?(?e))", RegexOptions.None, typeof(OutOfMemoryException))] |
Author
There was a problem hiding this comment.
This was a bad test, I've updated them in the latest commit
| [InlineData(" (?(?e))", RegexOptions.None, typeof(OutOfMemoryException))] | ||
| public void Ctor_InvalidPattern_NetCore(string pattern, RegexOptions options, Type exceptionType) | ||
| { | ||
| if (RuntimeInformation.FrameworkDescription.StartsWith(".NET Framework")) |
Contributor
There was a problem hiding this comment.
Rename the method to not have NetCore, since the test is also testing behavior on framework?
Priya91
approved these changes
Mar 2, 2017
Author
|
@dotnet-bot Test Innerloop Windows_NT Debug Build and Test |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…/corefx#16609) * Fix parsing of regex alternation construct with named options * Address PR feedback, correct some tests Commit migrated from dotnet/corefx@353bdc6
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1476
I've tried to add a bunch of targetted tests as well as a bunch of fuzzer-style tests. Let me know if you have any suggestions for others.