This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Test cleanup for System.Net.Security #15952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#3144 - Removed TODO because Begin/End were added back in #8358 and the issue is closed #7825 - Original issue from April 2016. Cannot repro today. Re-enabling to watch for future failures. #11170 - Can't repro failures on multiple OSs. Re-enabling to watch for future failures. #11345 - Outerloop tests are passing and stable for thousands of iterations. Tentatively moving to innerloop to watch for potential future failures. #12107 - removed TODO because issue is closed #9130, #10909, #11624, #14177, #14505 - duplicate issues failing because of an intermittent error (remote party closed transport stream) not exclusive to the test which occurs in Outerloop runs for other NetSecurity tests. Re-enabling them and leaving them in innerloop to get more data. #8744, #12683, #12706, #12728 - duplicate issues failing because of an intermittent error (credentials package not recognized) not exclusive to the test which occurs in Outerloop runs for other NetSecurity tests. Re-enabling them and leaving them in innerloop to get more data.
ianhays
added
area-System.Net.Security
test bug
stephentoub
reviewed
Feb 8, 2017
| @@ -6,8 +6,6 @@ | |||
| /// Task APM helper based on http://blogs.msdn.com/b/pfxteam/archive/2011/06/27/10179452.aspx | |||
| /// </summary> | |||
|
|
|||
| // TODO: #3144 - Remove this class and rewrite tests to work directly with TPL. | |||
There was a problem hiding this comment.
We should still be able to delete this helper, as we have a production version the tests can also use:
https://github.com/dotnet/corefx/blob/master/src/Common/src/System/Threading/Tasks/TaskToApm.cs
steveharter
approved these changes
Feb 8, 2017
ianhays
pushed a commit
that referenced
this pull request
Feb 9, 2017
* Test cleanup for System.Net.Security #3144 - Removed TODO because Begin/End were added back in #8358 and the issue is closed #7825 - Original issue from April 2016. Cannot repro today. Re-enabling to watch for future failures. #11170 - Can't repro failures on multiple OSs. Re-enabling to watch for future failures. #11345 - Outerloop tests are passing and stable for thousands of iterations. Tentatively moving to innerloop to watch for potential future failures. #12107 - removed TODO because issue is closed #9130, #10909, #11624, #14177, #14505 - duplicate issues failing because of an intermittent error (remote party closed transport stream) not exclusive to the test which occurs in Outerloop runs for other NetSecurity tests. Re-enabling them and leaving them in innerloop to get more data. #8744, #12683, #12706, #12728 - duplicate issues failing because of an intermittent error (credentials package not recognized) not exclusive to the test which occurs in Outerloop runs for other NetSecurity tests. Re-enabling them and leaving them in innerloop to get more data. * Remove unused netsecurity tests helper * Remove unused test helper
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Test cleanup for System.Net.Security dotnet/corefx#3144 - Removed TODO because Begin/End were added back in dotnet/corefx#8358 and the issue is closed dotnet/corefx#7825 - Original issue from April 2016. Cannot repro today. Re-enabling to watch for future failures. dotnet/corefx#11170 - Can't repro failures on multiple OSs. Re-enabling to watch for future failures. dotnet/corefx#11345 - Outerloop tests are passing and stable for thousands of iterations. Tentatively moving to innerloop to watch for potential future failures. dotnet/corefx#12107 - removed TODO because issue is closed dotnet/corefx#9130, dotnet/corefx#10909, dotnet/corefx#11624, dotnet/corefx#14177, dotnet/corefx#14505 - duplicate issues failing because of an intermittent error (remote party closed transport stream) not exclusive to the test which occurs in Outerloop runs for other NetSecurity tests. Re-enabling them and leaving them in innerloop to get more data. dotnet/corefx#8744, dotnet/corefx#12683, dotnet/corefx#12706, dotnet/corefx#12728 - duplicate issues failing because of an intermittent error (credentials package not recognized) not exclusive to the test which occurs in Outerloop runs for other NetSecurity tests. Re-enabling them and leaving them in innerloop to get more data. * Remove unused netsecurity tests helper * Remove unused test helper Commit migrated from dotnet/corefx@02b0fdb
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling and moving a bunch of disabled/outerlooped System.Net.Security tests to innerloop. I did extensive testing on Windows, RHEL, and Ubuntu machines and ensured the tests are stable (at least locally) and hit no errors. The next step is to re-enable them and watch to see if any of the failures resurface and disable them as needed.
resolves #3144 - Removed TODO because Begin/End were added back in #8358 and the issue is closed
resolves #7825 - Original issue from April 2016. Cannot repro today. Re-enabling to watch for future failures.
resolves #11170 - Can't repro failures on multiple OSs. Re-enabling to watch for future failures.
resolves #11345 - Outerloop tests are passing and stable for thousands of iterations. Tentatively moving to innerloop to watch for potential future failures.
resolves #12107 - removed TODO because issue is closed
resolves #9130 - duplicate issues failing because of an intermittent error (remote party closed transport stream) not exclusive to the test which occurs in Outerloop runs for other NetSecurity tests. Re-enabling them and leaving them in innerloop to get more data.
resolves #10909 - duplicate issues failing because of an intermittent error (remote party closed transport stream) not exclusive to the test which occurs in Outerloop runs for other NetSecurity tests. Re-enabling them and leaving them in innerloop to get more data.
resolves #11624 - duplicate issues failing because of an intermittent error (remote party closed transport stream) not exclusive to the test which occurs in Outerloop runs for other NetSecurity tests. Re-enabling them and leaving them in innerloop to get more data.
resolves #14177 - duplicate issues failing because of an intermittent error (remote party closed transport stream) not exclusive to the test which occurs in Outerloop runs for other NetSecurity tests. Re-enabling them and leaving them in innerloop to get more data.
resolves #14505 - duplicate issues failing because of an intermittent error (remote party closed transport stream) not exclusive to the test which occurs in Outerloop runs for other NetSecurity tests. Re-enabling them and leaving them in innerloop to get more data.
resolves #8744 - duplicate issues failing because of an intermittent error (credentials package not recognized) not exclusive to the test which occurs in Outerloop runs for other NetSecurity tests. Re-enabling them and leaving them in innerloop to get more data.
resolves #12683 - duplicate issues failing because of an intermittent error (credentials package not recognized) not exclusive to the test which occurs in Outerloop runs for other NetSecurity tests. Re-enabling them and leaving them in innerloop to get more data.
resolves #12706 - duplicate issues failing because of an intermittent error (credentials package not recognized) not exclusive to the test which occurs in Outerloop runs for other NetSecurity tests. Re-enabling them and leaving them in innerloop to get more data.
resolves #12728 - duplicate issues failing because of an intermittent error (credentials package not recognized) not exclusive to the test which occurs in Outerloop runs for other NetSecurity tests. Re-enabling them and leaving them in innerloop to get more data.
@steveharter @Priya91 @davidsh