This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Remove AccessControl OOM tests #15557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An OOM from the constructor isn't something we should even be testing in this case, especially not in an innerloop test. Better just to remove it.
ianhays
added
area-System.Security
test bug
|
LGTM |
stephentoub
approved these changes
Jan 28, 2017
dotnet-bot
pushed a commit
that referenced
this pull request
Jan 13, 2018
…tArray (#15557) * Make DangerousGetPinnableReference internal and remove DangerousTryGetArray * Change DangerousGetPinnableReference to return ref readonly Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
dotnet-bot
pushed a commit
that referenced
this pull request
Jan 13, 2018
…tArray (#15557) * Make DangerousGetPinnableReference internal and remove DangerousTryGetArray * Change DangerousGetPinnableReference to return ref readonly Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
safern
pushed a commit
that referenced
this pull request
Jan 16, 2018
…tArray (#15557) * Make DangerousGetPinnableReference internal and remove DangerousTryGetArray * Change DangerousGetPinnableReference to return ref readonly Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
safern
pushed a commit
that referenced
this pull request
Jan 16, 2018
…tArray (#15557) * Make DangerousGetPinnableReference internal and remove DangerousTryGetArray * Change DangerousGetPinnableReference to return ref readonly Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Remove AccessControl OOM tests Commit migrated from dotnet/corefx@9fa019b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An OOM from the constructor isn't something we should even be testing in this case, especially not in an innerloop test. Better just to remove it.
resolves https://github.com/dotnet/corefx/issues/15502