This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Support System.Reflection.Emit.ILGeneration tests on the full .NET Framework #14604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DnlHarvey @atsushikan @joshfree can you please review the change? |
stephentoub
reviewed
Jan 3, 2017
| @@ -28,10 +28,16 @@ public void ILGenerator_Int_Type(bool skipVisibility) | |||
| VerifyILGenerator(instanceCallBack, target, 0); | |||
| } | |||
|
|
|||
| [Fact] | |||
| [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "The coreclr ignores the skipVisibility value of DynamicMethod.")] | |||
| public void GetILGenerator_Int_Module_CoreclrIgnoresSkipVisibility() | |||
There was a problem hiding this comment.
Do we need a corresponding test that validates on .NET Framework that skipVisibility is not ignored?
dotnet-bot
pushed a commit
that referenced
this pull request
Jan 13, 2018
…ter. (#14604) Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
dotnet-bot
pushed a commit
that referenced
this pull request
Jan 13, 2018
…ter. (#14604) Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
safern
pushed a commit
that referenced
this pull request
Jan 16, 2018
…ter. (#14604) Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
safern
pushed a commit
that referenced
this pull request
Jan 16, 2018
…ter. (#14604) Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Support System.Reflection.Emit.ILGeneration tests on the full .NET Framework Commit migrated from dotnet/corefx@4b039b4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FieldAccessException, as the full .NET framework doesFixes #13252