Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Commit

Permalink
**Suppress implementation dependencies from compile.**
Browse files Browse the repository at this point in the history
Packages with ref and lib list all their dependencies
in a single section for that target framework.

This creates a couple problems:
1. Folks end up taking a dependency on the fact that a package
happens to use another package in its implementation.
2. For packages that have multiple implementations for the
same TFM and different RID all dependencies appear in the
same section even though some may be RID specific.
Those RID speicific dependencies will compatibility
errors during restore since the packages won't be supported
on all RIDs.
In lieu of the NuGet feature to represent RID-specific
dependencies NuGet/Home#1660
we can at least suppress the compatibility error by
excluding these implementation specific depdencies from
compile.

Further details are here:
dotnet/buildtools@d40435b#diff-abe065d40d7c72dbdc1ad1957148d23fR14

[tfs-changeset: 1581170]
  • Loading branch information
ericstj committed Mar 3, 2016
1 parent 664b573 commit 5a26b24
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
2 changes: 1 addition & 1 deletion BuildToolsVersion.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.0.25-prerelease-00182
1.0.25-prerelease-00183
5 changes: 0 additions & 5 deletions Packaging.props
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,6 @@
<PackagePlatform Condition="'$(PackagePlatform)' == ''">$(Platform)</PackagePlatform>
<PackagePlatform Condition="'$(PackagePlatform)' == 'amd64'">x64</PackagePlatform>
<NativePackagePath>$(MSBuildThisFileDirectory)src/Native/pkg</NativePackagePath>

<!-- Enable NETStandard -->
<UseNetPlatform>false</UseNetPlatform>
<BaseLinePackageDependencies>true</BaseLinePackageDependencies>
<ExcludeRuntimeJson>true</ExcludeRuntimeJson>
</PropertyGroup>

<PropertyGroup Condition="'$(OsEnvironment)'=='Unix'">
Expand Down

0 comments on commit 5a26b24

Please sign in to comment.