This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Reduce number of branches and IL size of string.Trim/TrimEnd/TrimStart methods #9115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-bot test OSX x64 Checked Build and Test |
|
Thanks! |
jkotas
approved these changes
Jan 25, 2017
|
@dotnet-bot test Ubuntu x64 Checked Build and Test (Failure to restore a package) |
|
@dotnet-bot test OSX x64 Checked Build and Test (Failed to restore the package) |
This was referenced Jan 28, 2017
This was referenced Feb 5, 2017
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the point where we use
fixed, we already know thechar[]is not null or empty, so we can reduce the number of branches and overall size of the method body by using the address of the first element. Based on the discussion here: dotnet/corefx#15432 (comment)cc: @stephentoub, @jkotas