Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Fix Mutex.ReleaseMutex exception type for compatibility #8941

Merged
merged 1 commit into from
Jan 13, 2017

Conversation

kouvel
Copy link

@kouvel kouvel commented Jan 13, 2017

The desktop framework throws ApplicationException

@kouvel
Copy link
Author

kouvel commented Jan 13, 2017

@jkotas
Copy link
Member

jkotas commented Jan 13, 2017

I assume there is/will be matching test added to corefx.

@jkotas jkotas merged commit 0ee13af into dotnet:master Jan 13, 2017
@kouvel kouvel deleted the WaitFixes branch January 13, 2017 21:25
@kouvel
Copy link
Author

kouvel commented Jan 13, 2017

Yes I'll add a test

@kouvel
Copy link
Author

kouvel commented Jan 14, 2017

On second thought, I'm going to postpone testing with invalid handles. There is absolutely no consistency when invalid handles are involved across .NET APIs, in some cases even Windows APIs are inconsistent in their behavior, and the current highly varying behaviors seem unreasonable. As for this particular API, yes it would be easy to add a test for it, but until we figure out what to do about these inconsistencies, it doesn't seem worth doing at all.

manofstick pushed a commit to manofstick/coreclr that referenced this pull request Jan 16, 2017
@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants