This repository was archived by the owner on Jan 23, 2023. It is now read-only.
JIT: remove match accounting from inliner state machine #8935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pgavlin PTAL |
|
LGTM |
The inliner's code-size estimating state machine keeps count of matches, but the count was only used in an assert that checked that the count did not overflow. The assert fired when jit stress drove the inliner to evaluate a huge method as a potential inline candidate and the count reached the overflow value. This change removes the counting and the related assert. Closes #8932.
AndyAyersMS
force-pushed
the
FixSmAssert
branch
from
4a16554 to
7a4db67
Compare
|
Fixed a couple of typos in the commit message. |
|
@dotnet-bot retest Linux ARM Emulator Cross Debug Build |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
JIT: remove match accounting from inliner state machine Commit migrated from dotnet/coreclr@9d01c0e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inliner's code-size estimating state machine keeps count of
matches, but the count was only used in an assert that checked
that the count did not overflow.
The assert fired when jit stress drove the inliner to evaluate a
huge method as a potential inline candidate and the count reached
the overflow value.
This change removes the counting and the related assert.
Closes #8932.