Stop build from leaving localpkg cache in src #8934
Conversation
| @@ -67,6 +67,9 @@ | |||
| <PackagesBinDir>$(__PackagesBinDir)</PackagesBinDir> | |||
| <PackagesBinDir Condition="'$(__PackagesBinDir)'==''">$(BinDir).nuget\</PackagesBinDir> | |||
|
|
|||
| <PackageInstallPath>$(__PackageInstallPath)</PackageInstallPath> | |||
There was a problem hiding this comment.
@karajas isn't there a way to disable the installing of this package instead of hacking the path here?
There was a problem hiding this comment.
Just set that property to disable installing this package locally as it isn't needed for you guys.
There was a problem hiding this comment.
@weshaggard where's the right place to set that property?
There was a problem hiding this comment.
In the packaging.props would be the place I think to set it. It needs to be set in all the pkgprojs essentially.
There was a problem hiding this comment.
Yeah SkipInstallLocallyBuiltPackages for any packages that you don't want installed.
There was a problem hiding this comment.
It looks like dir.props is the most reasonable place to set that property - the lowest level file that all the .pkgproj files import is the root-level dir.props (setting it in packages.builds did not work). I'll put up a PR to do so.
There was a problem hiding this comment.
OK. I guess you guys don't have a packages.props file like corefx. I would just put it where ever your other packaging properties are getting set.
|
Updated |
Stop build from leaving localpkg cache in src Commit migrated from dotnet/coreclr@b3136bb
https://github.com/dotnet/coreclr/issues/8130