Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Сhange children order in GenTreeBoundsChk. Fix #8077 #8806

Merged
merged 1 commit into from
Jan 12, 2017
Merged

Сhange children order in GenTreeBoundsChk. Fix #8077 #8806

merged 1 commit into from
Jan 12, 2017

Conversation

sandreenko
Copy link

@sandreenko sandreenko commented Jan 4, 2017 •
edited
Loading

Change childs order in GenTreeBoundsChk.
Index tree has to be executed before ArrLength.
It is possible to change only execution order, but this variant is more obvious.
Fix #8077.

@sandreenko sandreenko added the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Jan 4, 2017
@sandreenko sandreenko force-pushed the array-bounds-check branch 6 times, most recently from 54dddea to 6e75556 Compare January 7, 2017 01:23
@sandreenko sandreenko removed the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Jan 7, 2017
@sandreenko sandreenko changed the title [WIP] change childs order in GenTreeBoundsChk. Сhange childs order in GenTreeBoundsChk. Jan 7, 2017
@sandreenko sandreenko requested a review from pgavlin January 7, 2017 06:43
@sandreenko sandreenko changed the title Сhange childs order in GenTreeBoundsChk. Сhange children order in GenTreeBoundsChk. Fix #8077 Jan 8, 2017
@sandreenko
Copy link
Author

sandreenko commented Jan 8, 2017 •
edited
Loading

cc @hqueue

@sandreenko
Copy link
Author

PTAL @dotnet/jit-contrib

pgavlin
pgavlin approved these changes Jan 11, 2017
View reviewed changes
Copy link

@pgavlin pgavlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the everything but the legacy backend LGTM. @briansull can you take a look at the changes to codegenlegacy.cpp?

@sivarv
Copy link
Member

sivarv commented Jan 11, 2017

Please run SPMI diffs on x64 and ngen based asm diffs on legacy x86 to confirm either there are no asm diffs or the asm diffs are on expected lines.

@CarolEidt
Copy link

:shipit:

@briansull
Copy link

I took a look at codegenlegacy.cpp and it look correct upon inspection.

@sandreenko sandreenko merged commit 0adb691 into dotnet:master Jan 12, 2017
@sandreenko
Copy link
Author

Diffs look correct.
Thank you all.

@hqueue
Copy link
Member

hqueue commented Jan 16, 2017 •
edited
Loading

@sandreenko Sorry for late reply, I was AFK for a week.
It also works well with legacy backend for ARM including both arm and armel. Thanks!

Starting JIT/Regression/JitBlue/DevDiv_283795/DevDiv_283795/DevDiv_283795.sh
PASSED   - [   0][   2s]JIT/Regression/JitBlue/DevDiv_283795/DevDiv_283795/DevDiv_283795.sh
               BEGIN EXECUTION
               /opt/media/microsd/dotnet/unittest/coreoverlays/coreclr.test20170116.corefx.test20170111/corerun DevDiv_283795.exe
               Expected: 100
               Actual: 100
               END EXECUTION - PASSED

@sandreenko sandreenko deleted the array-bounds-check branch March 6, 2017 08:52
@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Merge pull request dotnet/coreclr#8806 from sandreenko/array-bounds-c…
c61e6b3 
…heck

Сhange children order in GenTreeBoundsChk. Fix dotnet/coreclr#8077

Commit migrated from dotnet/coreclr@0adb691
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pgavlin pgavlin pgavlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
8 participants
@sandreenko @sivarv @CarolEidt @briansull @hqueue @pgavlin @karelz @dnfclas