This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
TimeZoneInfo.StringSerializer: Avoid some unnecessary allocations #8783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using multiple calls to `string.Replace` to escape reserved chars before appending to a `StringBuilder`, do the replacing while appending the chars directly to the `StringBuilder`. Also, append numbers/dates directly instead of running it through the escape method, as these Invariant-formatted strings will not contain any chars that need to be escaped.
|
LGTM. |
|
test Ubuntu x64 Checked Build and Test please |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…tnet/coreclr#8783) Instead of using multiple calls to `string.Replace` to escape reserved chars before appending to a `StringBuilder`, do the replacing while appending the chars directly to the `StringBuilder`. Also, append numbers/dates directly instead of running it through the escape method, as these Invariant-formatted strings will not contain any chars that need to be escaped. Commit migrated from dotnet/coreclr@1d15b16
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using multiple calls to
string.Replaceto escape reserved chars before appending to aStringBuilder, do the replacing while appending the chars directly to theStringBuilder.Also, append numbers/dates directly instead of running it through the escape method, as these Invariant-formatted strings will not contain any chars that need to be escaped.
It's easiest to review ignoring whitespace (I removed an unnecessary null/length check to reduce indentation): https://github.com/dotnet/coreclr/pull/8783/files?w=1