This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Enable building linuxmscorlib / osxmscorlib with VS2015 #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AI, did I break this? Sorry about this edit Ah I see, it just wasn't working with vs2015 as an option so I didn't break it for normal user edit2 Not really sure why on my system it seems to work without this patch though... but either way looks god edit3 Hmz on another system I indeed see the error, currently the build is running with this patch applied on that system! Nice |
|
You might want to apply the same stuff here: https://github.com/dotnet/coreclr/blob/master/tests/runtest.cmd#L39 |
stephentoub
force-pushed
the
build_mscorlib_2015
branch
from
3c7a1bd to
6ccb666
Compare
Trying to do "build linuxmscorlib vs2015" was resulting in an error due to the script trying to read %_msbuildexe% when _msbuildexe hadn't been defined. When that was addressed, mscorlib was then also failing to compile due to the csc compiler not understanding a flag that was being set in the response file based on UseRoslynCompiler not being set. This commit addresses both issues.
stephentoub
force-pushed
the
build_mscorlib_2015
branch
from
6ccb666 to
2bac475
Compare
|
Thanks, @DickvdBrink. I've updated the commit with the same change to runtest.cmd. |
|
LGTM |
stephentoub
added a commit
that referenced
this pull request
Apr 29, 2015
Enable building linuxmscorlib / osxmscorlib with VS2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to do "build linuxmscorlib vs2015" was resulting in an error due to the script trying to read %_msbuildexe% when _msbuildexe hadn't been defined. When that was addressed, mscorlib was then also failing to compile due to the csc compiler not understanding a flag that was being set in the response file based on UseRoslynCompiler not being set. This commit addresses both issues.