This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
X86 GcEncode: Support V1 and V2 encodings #7237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swaroop-sridhar
commented
Sep 16, 2016
| @@ -92,12 +92,11 @@ PTR_CBYTE FASTCALL decodeHeader(PTR_CBYTE table, UINT32 version, InfoHdr* header | |||
|
|
|||
| BYTE nextByte = *table++; | |||
| BYTE encoding = nextByte & 0x7f; | |||
| const BYTE maskHaveMoreBytesBit = MORE_BYTES_TO_FOLLOW - 1; | |||
There was a problem hiding this comment.
This change is independent of allowing V1 for desktop.
It implements a change @briansull asked in this review: #6974 (comment)
|
@BruceForstall please review |
BruceForstall
approved these changes
Sep 16, 2016
| @@ -685,7 +684,7 @@ BYTE FASTCALL encodeHeaderNext(const InfoHdr& header, InfoHdr* state, BYTE &code | |||
| } | |||
| } | |||
|
|
|||
| if (state->revPInvokeOffset != header.revPInvokeOffset) | |||
| if (GCInfoEncodesRevPInvokeFrame() && (state->revPInvokeOffset != header.revPInvokeOffset)) | |||
| { | |||
| _ASSERTE(GCInfoEncodesRevPInvokeFrame()); | |||
There was a problem hiding this comment.
You don't need this assert now.
The RYU+LegacyBackend Desktop JIT for X86 is still on V1. So, permit both V1 and V2 encodings in gcencode.cpp.
swaroop-sridhar
force-pushed
the
gc86legacy
branch
from
e5200c8 to
e7ece61
Compare
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
X86 GcEncode: Support V1 and V2 encodings Commit migrated from dotnet/coreclr@217ba4d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RYU+LegacyBackend Desktop JIT for X86 is still on V1.
So, permit both V1 and V2 encodings in gcencode.cpp.