This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
GcInfo: Report Struct containing one GcPointer correctly #7013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jkotas, @briansull: please review |
|
@dotnet-bot test Ubuntu gcstress0xc |
| BYTE gcPtrs[2] = {TYPE_GC_NONE, TYPE_GC_NONE}; | ||
| compiler->info.compCompHnd->getClassGClayout(structType, gcPtrs); | ||
| case TYP_REF: | ||
| case TYP_ARRAY: |
There was a problem hiding this comment.
TYP_ARRAY is never returned by getReturnTypeForStruct, it is confusing to include it here.
|
LGTM with comments |
This change fixes a bug in the the GcInfo header, where the ReturnKind is reported incorrectly for certain structs. Structs that contain only one GCPointer or ByRef, can be returned in a single register (Windows/Unix/OSX). The ReturnKind for these struct-returns should be RT_Object/RT_ByRef, but they are currently incorrectly reported as RT_Scalar. This change fixes the problem. Fixes: dotnet/corefx#11260
swaroop-sridhar
force-pushed
the
PtrStruct
branch
from
2c8b716 to
060e0c6
Compare
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
GcInfo: Report Struct containing one GcPointer correctly Commit migrated from dotnet/coreclr@68afd5c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a bug in the the GcInfo header,
where the ReturnKind is reported incorrectly for certain structs.
Structs that contain only one GCPointer or ByRef, can be returned
in a single register (Windows/Unix/OSX). The ReturnKind for these
struct-returns should be RT_Object/RT_ByRef, but they are currently
incorrectly reported as RT_Scalar. This change fixes the problem.
Fixes: dotnet/corefx#11260