This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
GcInfo: Don't use slim header for methods with struct-returns #6908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This checkin has two changes: 1) Add a check to ensure that methods with struct-returns are use the fat header which encodes ReturnKind in 4 bits. 2) Fix a bug in GetReturnKind().
|
@dotnet-bot test Ubuntu gcstress0xc |
|
Th failure in Windows_NT gcstress is pre-existing. Ubuntu gcstress 0xC is still running, but several tests have passed. |
|
@rahku please review |
|
LGTM |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
GcInfo: Don't use slim header for methods with struct-returns Commit migrated from dotnet/coreclr@dc52f8b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checkin has two changes:
use the fat header which encodes ReturnKind in 4 bits.
Fixes #6862