This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Inliner: improve arg observations #6337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two related changes to better capture cases where args or constant args are seen at inline call sites. On the observation side, the inliner's stack modelling of the callee is crude and will often overestimate the evaluation stack depth. So when looking at an opcode that takes just one stack operand (eg BRFALSE) the inliner's check should be whether the stack has at least one element instead of checking whether the stack has exactly one element. For compatibility reasons, the check for exactly one element is still used when the inline is evaluated via the LegacyPolicy. On the policy side, instead of keeping a bool flag to note that there were interesting arg cases, count the number of observations. LegacyPolicy continues to act as before, checking if count is zero or nonzero instead of whether the flag was false or true. The count is available for use in other heuristics and is reported in inline data.
|
@kyulee PTAL |
|
@mikedn If this goes in before your change we'll want to update the new policy you're adding to override |
|
LGTM |
|
ARM failures are known issues; Ubuntu tests passed but the leg failed at the very end in the post processing. So will ignore all these. |
|
@dotnet-bot retest Ubuntu x64 Checked Build and Test |
|
Retrying Ubuntu to see if the netci.groovy reversion in #6336 really fixed the leg. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…ions Inliner: improve arg observations Commit migrated from dotnet/coreclr@7288deb
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two related changes to better capture cases where args or constant args
are seen at inline call sites.
On the observation side, the inliner's stack modelling of the callee is
crude and will often overestimate the evaluation stack depth. So when
looking at an opcode that takes just one stack operand (eg BRFALSE) the
inliner's check should be whether the stack has at least one element
instead of checking whether the stack has exactly one element. For
compatibility reasons, the check for exactly one element is still used
when the inline is evaluated via the LegacyPolicy.
On the policy side, instead of keeping a bool flag to note that there
were interesting arg cases, count the number of observations.
LegacyPolicy continues to act as before, checking if count is zero or
nonzero instead of whether the flag was false or true. The count is
available for use in other heuristics and is reported in inline data.