Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Revert "Less conservative gt obj" #6227

Merged
merged 1 commit into from
Jul 19, 2016

Conversation

parjong
Copy link

@parjong parjong commented Jul 12, 2016

Reverts #6021 to fix #6179

@leemgs
Copy link

leemgs commented Jul 12, 2016

Actually, We have been getting the 400+ unit-test failures on Raspberry Pi2 board after merging #6021.
Acked-by: Geunsik Lim geunsik.lim@samsung.com

@leemgs
Copy link

leemgs commented Jul 12, 2016

@jkotas , Please, take a look at the regression issue of #6021.

@jkotas
Copy link
Member

jkotas commented Jul 12, 2016

@CarolEidt @dotnet/jit-contrib What is the best way to proceed on this one?

@CarolEidt
Copy link

I have not been able to install the emulator to attempt to repro this issue. Before backing out the change, I would like to be able to repro the failure - otherwise I see no way forward. In the meantime, I am attempting to repro #6222 to see if it is related or the same.

@RussKeldorph
Copy link

@parjong Could you close this and create a new PR with the same change against current master so we can see the Linux test results with the latest CI changes? Note that it's not sufficient to simply request re-test due to a bug in the CI system.

@ghost
Copy link

ghost commented Jul 16, 2016

@RussKeldorph, perhaps @parjong can just rebase against the master and re-pushed:

cd coreclr
git checkout revert-6021-LessConservativeGtObj
git remote add dotnet https://github.com/dotnet/coreclr
git pull --rebase dotnet master
git push -f

@parjong parjong force-pushed the revert-6021-LessConservativeGtObj branch from 309995a to 5524e2b Compare July 17, 2016 23:40
@parjong
Copy link
Author

parjong commented Jul 17, 2016

@RussKeldorph I rebased this PR as per @jasonwilliams200OK's suggestion. (Thank you @jasonwilliams200OK 👍 )

@RussKeldorph
Copy link

@parjong Thank you. I wasn't expecting that to work due to the CI bug I mentioned, but perhaps it did. It looks like the tests in question (b26496 & b539509) are passing as expected.

@briansull
Copy link

@RussKeldorph I note that the ARM32 Release tests still are hitting the Seg-Fault failure:

Tests b26863.exe gets a Seg Fault in this test run
http://dotnet-ci.cloudapp.net/job/dotnet_coreclr/job/master/job/arm_emulator_cross_release_ubuntu_prtest/548/

@RussKeldorph
Copy link

@briansull Yes, I noticed that as well.

@dotnet-bot test Linux ARM Emulator Cross Release Build

@CarolEidt
Copy link

I'm going to merge this, as I am still unable to successfully build and run the emulator to track down the regression.

@CarolEidt CarolEidt merged commit 93f09db into dotnet:master Jul 19, 2016
@parjong parjong deleted the revert-6021-LessConservativeGtObj branch July 19, 2016 06:34
@RussKeldorph
Copy link

We'd like to try to get a repro on Raspberry Pi 2 so @CarolEidt can investigate these failures. @leemgs, you mention above that you are seeing 400+ failures on Raspberry Pi 2 with #6021. Is that running under Ubuntu? If so, which version? We're trying 14.04 and 16.04 and in both cases seeing

coreclr_initialize failed - status: 0x80004005

when attempting to run any test. Are the ARM instructions up to date and confirmed working on current sources?

@leemgs
Copy link

leemgs commented Jul 20, 2016

Is that running under Ubuntu? If so, which version?

Under Ubuntu/ARM 14.04 32bit, On Raspberry Pi2 & ARM ChromeBook

picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
…onservativeGtObj

Revert "Less conservative gt obj"

Commit migrated from dotnet/coreclr@93f09db
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ARM/Linux] Regression in Unittest - Exception.ToString() failed
7 participants