-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Revert "Less conservative gt obj" #6227
Revert "Less conservative gt obj" #6227
Conversation
Actually, We have been getting the 400+ unit-test failures on Raspberry Pi2 board after merging #6021. |
@CarolEidt @dotnet/jit-contrib What is the best way to proceed on this one? |
I have not been able to install the emulator to attempt to repro this issue. Before backing out the change, I would like to be able to repro the failure - otherwise I see no way forward. In the meantime, I am attempting to repro #6222 to see if it is related or the same. |
@parjong Could you close this and create a new PR with the same change against current master so we can see the Linux test results with the latest CI changes? Note that it's not sufficient to simply request re-test due to a bug in the CI system. |
@RussKeldorph, perhaps @parjong can just rebase against the master and re-pushed: cd coreclr
git checkout revert-6021-LessConservativeGtObj
git remote add dotnet https://github.com/dotnet/coreclr
git pull --rebase dotnet master
git push -f |
309995a
to
5524e2b
Compare
@RussKeldorph I rebased this PR as per @jasonwilliams200OK's suggestion. (Thank you @jasonwilliams200OK 👍 ) |
@parjong Thank you. I wasn't expecting that to work due to the CI bug I mentioned, but perhaps it did. It looks like the tests in question (b26496 & b539509) are passing as expected. |
@RussKeldorph I note that the ARM32 Release tests still are hitting the Seg-Fault failure: Tests b26863.exe gets a Seg Fault in this test run |
@briansull Yes, I noticed that as well. @dotnet-bot test Linux ARM Emulator Cross Release Build |
I'm going to merge this, as I am still unable to successfully build and run the emulator to track down the regression. |
We'd like to try to get a repro on Raspberry Pi 2 so @CarolEidt can investigate these failures. @leemgs, you mention above that you are seeing 400+ failures on Raspberry Pi 2 with #6021. Is that running under Ubuntu? If so, which version? We're trying 14.04 and 16.04 and in both cases seeing
when attempting to run any test. Are the ARM instructions up to date and confirmed working on current sources? |
Under Ubuntu/ARM 14.04 32bit, On Raspberry Pi2 & ARM ChromeBook |
…onservativeGtObj Revert "Less conservative gt obj" Commit migrated from dotnet/coreclr@93f09db
Reverts #6021 to fix #6179