This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
ARM64: Don't track LR as part of NV-Context #5666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _pc and _sp fields actually refer to the caller's PC and SP values. So, remove read/writes of LR in captureX19_X29 array of ARM64 MachState. This change fixes a buffer overflow problem.
|
@dotnet-bot test Windows_NT arm64 Checked |
|
@rahku please review |
|
Thanks. Looks good. |
|
Looks Good |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
ARM64: Don't track LR as part of NV-Context Commit migrated from dotnet/coreclr@6ff6621
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _pc and _sp fields actually refer to the caller's PC and SP values.
So, remove read/writes of LR in captureX19_X29 array of ARM64 MachState.
This change fixes a buffer overflow problem.