This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix reporting of callee saved registers with nongnu libuwind #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The callee saved registers were not preserved for GC stackwalk with nongnu libunwind that does not provide context pointers. Fixed by adding an extra space to MachState to preserve them. To avoid large amounts of copy&pasted code, introduced macro to enumerate all callee saved registers, similar to existing macro to enumerate all argument registers. This macro makes the code to copy the register values between different structures more compact, and less prone to typos.
| CALLEE_SAVED_REGISTER(Rbx) \ | ||
| CALLEE_SAVED_REGISTER(Rbp) | ||
|
|
||
| #define NUM_CALLEE_SAVED_REGISTERS 8 |
There was a problem hiding this comment.
I think this should be 6 instead of 8?
There was a problem hiding this comment.
Good catch! The memory corruptions from this typo would not be fun to trace down.
jkotas
force-pushed
the
macunwind
branch
2 times, most recently
from
b7f15e1 to
b3a674a
Compare
|
Addressed code review feedback. @sergiy-k PTAL |
| }; | ||
|
|
||
| struct CalleeSavedRegistersPointers { | ||
| #define CALLEE_SAVED_REGISTER(regname) PTR_TADDR regname; |
There was a problem hiding this comment.
I think this needs to be p##regname instead of regname like in other places. Otherwise it will cause a build break.
There was a problem hiding this comment.
Yes, I forgot to commit the change - it is fixed now.
|
LGTM. |
|
LGTM |
jkotas
added a commit
that referenced
this pull request
Mar 23, 2015
Fix reporting of callee saved registers with nongnu libuwind
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callee saved registers were not preserved for GC stackwalk with nongnu
libunwind that does not provide context pointers. Fixed by adding an extra
space to MachState to preserve them.
To avoid large amounts of copy&pasted code, introduced macro to enumerate
all callee saved registers, similar to existing macro to enumerate all
argument registers. This macro makes the code to copy the register values
between different structures more compact, and less prone to typos.
This is fixing #512