This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Port from tfs: onload exception debugger crash fix #4868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ExceptionHijackPersonalityRoutine was retrieving a context from a particular stack frame, but the calling conventions for the function executing in that frame allow it to overwrite the context. This was causing the debugger to crash for exceptions thrown from the onload method in winforms on x64. The fix is to instead retrieve the context from the previous stack frame, whose layout is set up explicitly in ExceptionHijack.
|
Hi @sbomer, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
|
@sbomer, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
Member
|
cc @noahfalk |
Member
|
LGTM |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
The ExceptionHijackPersonalityRoutine was retrieving a context from a particular stack frame, but the calling conventions for the function executing in that frame allow it to overwrite the context. This was causing the debugger to crash for exceptions thrown from the onload method in winforms on x64. The fix is to instead retrieve the context from the previous stack frame, whose layout is set up explicitly in ExceptionHijack. Commit migrated from dotnet/coreclr@f1d6f7a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ExceptionHijackPersonalityRoutine was retrieving a context from a
particular stack frame, but the calling conventions for the function
executing in that frame allow it to overwrite the context. This was
causing the debugger to crash for exceptions thrown from the onload
method in winforms on x64.
The fix is to instead retrieve the context from the previous stack
frame, whose layout is set up explicitly in ExceptionHijack.