This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
GCInfo: Fix code-offset normalization on ARM #4481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix NORMALIZE_CODE_OFFSET() on ARM to be a loss-less encoding because safepoint code-offsets are encoded with a -1 adjustment.
|
@rahku please review |
|
Looks good. But this would increase the gcinfo size for arm. There is potential to reduce size of gcinfo for both arm & arm64 by making normcallsite to be callsite -2 & callsite -4 for arm & arm64 respectively. We should look into doing this work as part of arm64 port. |
|
Opened #4497 to address the issue of saving bits in the encoding on ARM/ARM64. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
GCInfo: Fix code-offset normalization on ARM Commit migrated from dotnet/coreclr@0ce162f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix NORMALIZE_CODE_OFFSET() on ARM to be a loss-less encoding
because safepoint code-offsets are encoded with a -1 adjustment.
This change fixes a build break on ARM, failing this assertion:
https://github.com/dotnet/coreclr/blob/master/src/gcinfo/gcinfoencoder.cpp#L1220