This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
ARM64: Fix GC encoding settings #4377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-bot test Windows_NT arm64 |
|
@dotnet-bot test Windows_NT arm64 Checked |
|
@rahku please review |
|
#3825 |
|
@dotnet-bot test Windows_NT arm64 Checked |
| #define DENORMALIZE_STACK_BASE_REGISTER(x) ((x) ^ 5) | ||
| #define NORMALIZE_CODE_LENGTH(x) ((x)>>2) // All Instructions are 4 bytes long | ||
| #define DENORMALIZE_CODE_LENGTH(x) ((x)<<2) | ||
| #define NORMALIZE_STACK_BASE_REGISTER(x) ((x)^29) // Encode Frame pointer X29 as zero |
There was a problem hiding this comment.
can you check what we do for arm arch applies for arm64
There was a problem hiding this comment.
NORMALIZE_STACK_BASE_REGISTER() encodes FP as 0 and SP as 2, to minimize the number of bits necessary to encode the base-register for reported stack slots. So, I believe this encoding is sufficient for ARM64.
This change fixes certain settings in the GCInfo encoder/decoders. It also fixes the debug info for the stack pointer.
|
@dotnet-bot test Windows_NT arm64 Checked |
|
Looks good |
|
@dotnet-bot test Ubuntu x64 Checked |
|
@dotnet-bot retest this please |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
ARM64: Fix GC encoding settings Commit migrated from dotnet/coreclr@ce80d93
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes certain settings in the GCInfo encoder/decoders.
It also fixes the debug info for the stack pointer.