This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
GCInfo: Fix ARM64 GCInfo decoding #4279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCStress traps were not inserted in ARM64 code correctly because safepoint offsets were not correctly computed by EnumerateSafepoints(). This change fixes the issue by adding the (-1) adjustment to the ARM64 Safepoint offsets, similar to ARM and AMD64.
|
@rahku please review |
| @@ -440,6 +440,12 @@ void GcInfoDecoder::EnumerateSafePoints(EnumerateSafePointsCallback *pCallback, | |||
| { | |||
| UINT32 normOffset = (UINT32)m_Reader.Read(numBitsPerOffset); | |||
| UINT32 offset = DENORMALIZE_CODE_OFFSET(normOffset) + 2; | |||
|
|
|||
There was a problem hiding this comment.
EnumerateSafepoints() is currently not used on the AMD64 GCStress path.
|
Fixes #3824 |
|
@dotnet-bot test Windows_NT arm64 |
|
@dotnet-bot test Windows_NT arm64 Checked |
|
looks good. Can you also make change at other places in file src/vm/gcinfodecoder.cpp . |
|
OK thanks @rahku. I'll checkin this change, since testing is green. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
GCInfo: Fix ARM64 GCInfo decoding Commit migrated from dotnet/coreclr@ae2d2f3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCStress traps were not inserted in ARM64 code correctly because safepoint
offsets were not correctly computed by EnumerateSafepoints().
This change fixes the issue by adding the (-1) adjustment to the ARM64
Safepoint offsets, similar to ARM and AMD64.