Generate map files for symbol resolution for Linux native images on PerfView #4068
Conversation
|
Hi @Lucrecious, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
|
@Lucrecious, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
|
@brianrob Hey, could you review this? |
| } | ||
| } | ||
|
|
||
| // Log an IL image load to the map. |
There was a problem hiding this comment.
Please remove IL from the comment, as this can be any managed image (IL, NGEN, R2R).
|
LGTM. Please also squash your commits. |
|
@brianrob I think the commits have been squashed correctly, you can look through the changed files to make sure :) |
| LIMITED_METHOD_CONTRACT; | ||
|
|
||
| WCHAR tempPath[MAX_LONGPATH+1]; | ||
| if (!GetTempPathW(MAX_LONGPATH, tempPath)) |
There was a problem hiding this comment.
We have recently tried to erradicate all fixed size buffers from the codebase. Please use WszGetTempPath with SString parameter instead.
There was a problem hiding this comment.
@janvorli Hey, I fixed this in the latest iteration! Thanks.
Generate map files for symbol resolution for Linux native images on PerfView Commit migrated from dotnet/coreclr@0ec739e
We are trying to enable performance investigations for Linux on Windows through PerfView.
Part of this plan requires the ability to map unknown symbols to their resolved symbols from the running program's native images. We do this by having the CoreCLR generate perfinfo-%d.map files (where %d is the running process' ID). perfinfo-%.map files that contain all the dlls loaded for the specific process and this helps us generate map files with symbol mappings for all managed code dlls.