This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Restore IBCMerge using an authenticated service connection #24284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nticated-feed-ibc-restore
…actual command output.
jkoritzinsky
requested review from
RussKeldorph,
brianrob,
briansull and
michellemcdaniel
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…reclr#24284) * Add separate build steps to do the IBCMerge restore. * Attempt 1 to get config picked up. * Attempt 2 getting ibcmerge restore working. * Fix invalid MSBuild syntax. * Fix getting IBC package version. Commit migrated from dotnet/coreclr@9cf8b4b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IBCMerge package is stored on an authenticated feed. As a result, we need to pass along the authentication information to the restore process. This PR implements a method similar to CoreFX where we use a pre-made service connection to pull down the package.
However, to use a service connection, we need to do this step as a separate step on AzDO. Additionally, we need a .NET CLI installed before doing this step. So, this PR also installs a .NET CLI onto the system separate from the one we use during build (we set
DOTNET_MULTILEVEL_LOOKUP=0already in our scripts so we don't do multi-level lookup).Fixes #24247
See https://dev.azure.com/dnceng/internal/_build/results?buildId=171677 for succeeding official builds with IBC enabled.