This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Remove fixed sign tool version #23182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jashook
approved these changes
Mar 11, 2019
Member
Author
|
@dotnet-bot test Windows_NT x86 Release Innerloop Build and Test |
Member
Author
|
/azp run coreclr-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
Merging. This won't trigger any CI change and was already tested manually for release bits. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23081
Tested with SignTool version
1.0.0-beta.19159.2as test signed in https://dev.azure.com/dnceng/internal/_build/results?buildId=120800 and signing step succeeded. Manually downloaded the ARM binaries to verify that SPC is crossgened and signed with a proper Microsoft issued SHA256 cert.cc: @RussKeldorph @jashook