Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

@grant-d
Copy link

@grant-d grant-d commented Feb 13, 2019

RotateLeft, RotateRight

There are several implementations of RotateLeft and RotateRight in the stack.

  • This PR consolidates them into a central class
  • The actual implementations are unchanged, ie uses the same standard idioms from original callsites
  • All BitOps methods pass units

Unlike the related PRs (LZCNT, TZCNT) where the goal was to fix & optimize the code,
the benefits here are:

  • Less proliferation of identical helpers
  • Existing code/callsites are more self-documenting
  • New code can use these new pseudo-intrinsics
  • Dependency/profile analysis

Note related JIT optimization which makes all such methods pseudo-intrinsic: #1830

PopCount

For PopCount, the goal is to:

  • Centralize and optimize existing (mostly downstream) callsites (eg1, eg2)
  • Provide optimized utility methods for new code to use

TrailingZeroCount

  • Perf tweak in TrailingZeroCount related to MSIL generation (removing redundant conv.u8)

cc @tannergooding

@grant-d
Copy link
Author

grant-d commented Feb 14, 2019

@dotnet-bot test this please

@grant-d
Copy link
Author

grant-d commented Feb 14, 2019

@dotnet-bot test coreclr-ci (Build Linux arm debug) please
@dotnet-bot test coreclr-ci (Build Linux arm release) please

@grant-d
Copy link
Author

grant-d commented Feb 14, 2019

/azp run coreclr-ci

@grant-d
Copy link
Author

grant-d commented Feb 14, 2019

/azp run

@grant-d
Copy link
Author

grant-d commented Feb 14, 2019

Lots of infra failures
Not sure how to get the azp tasks to restart.
Per https://github.com/dotnet/corefx/issues/35121#issuecomment-462849658 my commands should work, maybe I don't have permissions?
cc @safern

@safern
Copy link
Member

safern commented Feb 14, 2019

Based on my conversation with Azure Devops folks, you have to be collaborator in order to be able to trigger builds from comments, I think contributors can't do it yet 😢

@safern
Copy link
Member

safern commented Feb 14, 2019

/azp run coreclr-ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@grant-d
Copy link
Author

grant-d commented Feb 14, 2019

@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test please
@dotnet-bot test Windows_NT x64 Release CoreFX Tests please

@jkotas
Copy link
Member

jkotas commented Feb 14, 2019

@safern Are you able to make sense of all the failing Azure Pipelines tasks on this PR? Are they all infrastructure issues?

@grant-d
Copy link
Author

grant-d commented Feb 14, 2019

@dotnet-bot test Windows_NT x64 Release CoreFX Tests please

@grant-d
Copy link
Author

grant-d commented Feb 14, 2019

This last check is failing on a ping test, which sounds like infra. Hopefully it goes through this time

@jkotas jkotas merged commit b4f99f2 into dotnet:master Feb 14, 2019
@jkotas
Copy link
Member

jkotas commented Feb 14, 2019

Thanks!

@grant-d grant-d deleted the grant-d.rotl branch February 14, 2019 21:52
@grant-d
Copy link
Author

grant-d commented Feb 14, 2019

Thanks again @jkotas, once again the feedback is appreciated. Always something new to learn here.

Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/mono that referenced this pull request Feb 14, 2019
* Perf: BitOps.LeadingZeroCount

* Remove redundant MSIL cast, conv.u8

* Use local functions for SoftwareFallback

* Target BIT32/64

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
marek-safar pushed a commit to mono/mono that referenced this pull request Feb 14, 2019
* Perf: BitOps.LeadingZeroCount

* Remove redundant MSIL cast, conv.u8

* Use local functions for SoftwareFallback

* Target BIT32/64

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/corert that referenced this pull request Feb 15, 2019
* Perf: BitOps.LeadingZeroCount

* Remove redundant MSIL cast, conv.u8

* Use local functions for SoftwareFallback

* Target BIT32/64

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas pushed a commit to dotnet/corert that referenced this pull request Feb 15, 2019
* Perf: BitOps.LeadingZeroCount

* Remove redundant MSIL cast, conv.u8

* Use local functions for SoftwareFallback

* Target BIT32/64

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/corefx that referenced this pull request Feb 15, 2019
* Perf: BitOps.LeadingZeroCount

* Remove redundant MSIL cast, conv.u8

* Use local functions for SoftwareFallback

* Target BIT32/64

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas pushed a commit to dotnet/corefx that referenced this pull request Feb 15, 2019
* Perf: BitOps.LeadingZeroCount

* Remove redundant MSIL cast, conv.u8

* Use local functions for SoftwareFallback

* Target BIT32/64

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
* Perf: BitOps.LeadingZeroCount

* Remove redundant MSIL cast, conv.u8

* Use local functions for SoftwareFallback

* Target BIT32/64

Commit migrated from dotnet/coreclr@b4f99f2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants