This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Maintain left.Equals(right) order for equality for compat #21829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm assuming |
|
SortVersion is sealed as well, so it can stay as is as well. |
|
Version is sealed as well. |
benaadams
force-pushed
the
equals-order
branch
from
2cf506f to
cc1cb5c
Compare
|
Backed out |
mikedn
reviewed
Jan 6, 2019
| @@ -22,7 +22,6 @@ public abstract partial class ConstructorInfo : MethodBase | |||
| public override bool Equals(object obj) => base.Equals(obj); | |||
| public override int GetHashCode() => base.GetHashCode(); | |||
|
|
|||
| // Force inline as the true/false ternary takes it above ALWAYS_INLINE size even though the asm ends up smaller | |||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | |||
There was a problem hiding this comment.
@benaadams Did you intend to delete only the comment, not the associated attribute?
There was a problem hiding this comment.
Yeah, as I think its inaccurrate now (saying its actually a very small method that's just misunderstood by the Jit)
sandreenko
pushed a commit
to sandreenko/coreclr
that referenced
this pull request
Jan 8, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
This was referenced Feb 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seen in dotnet/corefx#34375 (comment)
/cc @jkotas @stephentoub