Port to release/2.1 - Fix hijack for ARM/ARM64/x86 on Unix #20116
Conversation
* Fix hijacking for ARM/ARM64/x86 on Unix We were not checking the case when we have interrupted a thread inside of a function epilog for other architectures than amd64. When such an interruption happens, GS cookie check in a stack walking has failed, since we are unable to decode GS cookie location when the IP is in epilog. This fix implements IsIPInEpilog for all architectures and makes the check unconditional.
janvorli
added
area-VM
arch-arm64
arch-x86
arch-arm32
Servicing-consider
leecow
added
Servicing-approved
|
@dotnet-bot test Windows_NT x86 Checked Innerloop Build and Test |
|
All test failures caused by issue fixed by pending #20124 |
|
@dotnet-bot test Windows_NT x86 Checked Innerloop Build and Test |
|
@dotnet-bot test Windows_NT arm Cross Checked Innerloop Build and Test please |
|
@dotnet-bot test Windows_NT arm64 Cross Checked Innerloop Build and Test please |
|
This change can be merged in, the Windows_NT arm / arm64 take several days to get scheduled and then they fail due to missing artifacts. This change is Unix only anyways. |
Description
We were not checking the case when we have interrupted a thread inside
of a function epilog for other architectures than amd64. When such an
interruption happens, GS cookie check in a stack walking has failed,
since we are unable to decode GS cookie location when the IP is in
epilog.
Customer Impact
Customer's application terminates on ARM, ARM64 or x86 Unix due to fail fast when a thread is suspended for GC while running in a function epilog.
Regression?
No
Risk
No
Original issue: #20015