This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[release/2.2] Startup hook provider #20005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmoseley
reviewed
Sep 17, 2018
| @@ -364,6 +364,7 @@ | |||
| <Compile Include="$(BclSourcesRoot)\System\WeakReference.cs" /> | |||
| <Compile Include="$(BclSourcesRoot)\System\WeakReferenceOfT.cs" /> | |||
| <Compile Include="$(BclSourcesRoot)\System\CLRConfig.cs" /> | |||
| <Compile Include="$(BclSourcesRoot)\System\StartupHookProvider.cs" /> | |||
There was a problem hiding this comment.
Nit, alpha order is good because it tends to reduce merge conflicts
There was a problem hiding this comment.
Fixed here and in master: #20028
danmoseley
reviewed
Sep 17, 2018
| } | ||
| if (PathInternal.IsPartiallyQualified(startupHook)) | ||
| { | ||
| throw new ArgumentException(SR.Argument_AbsolutePathRequired); |
There was a problem hiding this comment.
This will just say Absolute path information is required. without any indication of what the path was or where it came from.
There was a problem hiding this comment.
The stack trace will indicate that the exception came from the startup hook path. This is the same exception we throw elsewhere from SPC for non-absolute path info. Sometimes we also include the name of the variable containing the path, but that wouldn't help in this case since it's a local that could be any of the hooks.
There was a problem hiding this comment.
I may make a pass in master in future to add the path (if it exists) to all uses of Argument_AbsolutePathRequired... 😄
RussKeldorph
added
the
Servicing-consider
sbomer
added a commit
to sbomer/coreclr
that referenced
this pull request
Sep 18, 2018
For consistency with dotnet#20005
jamshedd
added
Servicing-more-info
and removed
Servicing-consider
* Add startup hook in System.Private.CoreLib ProcessStartupHooks can be called from the host before the user's Main entry point. It receives a list of dlls and types containing Initialize() methods that will be called, making it possible to inject managed code early during startup. * Allow ! in assembly path for startup hook and other changes Also: - Report full assembly path when startup hook assembly is not found - Remove unnecessary assert - use Type.Delimiter instead of "." * Use C# 7 tuple syntax and remove assert * Improve error handling Throw MissingMethodException only when there aren't any Initialize methods at all. When there are Initialize methods with incorrect signatures (parameters, return type, visibility, or instance methods), throw invalid signature error. This should improve diagnosability of this feature. * Remove eager check for missing startup hook assemblies * Require full assembly path and use Split(char) overload. * Remove startup hook type syntax The type is now required to be "StartupHook" (in the global namespace). * Add assembly path to startup signature exception With a hard-coded type name, printing the type.method of the startup hook in the exception will no longer be much of an aid in debugging startup hook signature issues. Adding the assembly path makes it clear which startup hook had the problem. * Use const strings * Call startup hook inside ExecuteMainMethod This way it will be called when the application is executed, but not during other uses of hosting apis that go through coreclr_create_delegate. This change will ensure that the threading state is set based on attributes in the main method, before the startup hooks run. * Run startup hooks after setting root assembly and other fixes - Run startup hooks after setting the appdomain's root assembly (visible in Assembly.GetEntryAssembly() - Make the class static - Remove debug output - Don't allocate an empty ARG_SLOT array * Allow non-public Initialize method, adjust coding style * Remove overly-specific assert
sbomer
force-pushed
the
portStartupHook
branch
from
9d35a55 to
1162fe9
Compare
RussKeldorph
added
Servicing-consider
vivmishra
added
Servicing-approved
|
Approved for 2.2 RTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a hook that lets an environment variable specify managed code to be run before
Main, allowing early customization in managed code.Tracking issue: https://github.com/dotnet/coreclr/issues/20004
Customer Impact
This feature will enable Service Fabric to ship updates to their shared assemblies. They intend to use the startup hook to handle resolution for these shared assemblies.
Regression?
Not a regression.
Risk
Low. This shouldn't impact any old functionality.