Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Clean up build.cmd/build-test.cmd/runtest.cmd #19291

Merged
merged 1 commit into from
Aug 7, 2018
Merged

Clean up build.cmd/build-test.cmd/runtest.cmd #19291

merged 1 commit into from
Aug 7, 2018

Conversation

BruceForstall
Copy link

Various minor cleanups:

  1. Use the same naming/style for all three.
  2. Make the style consistent throughout each. E.g., consistent indents,
    capitalization.
  3. Add more consistent output, including the prefix tag used everywhere.
  4. build.cmd: only build cross components if native build is enabled.
  5. Use new __Logging variable to consolidate all logging arguments,
    to reduce large (unexpanded) command line lengths.

@BruceForstall
Copy link
Author

@dotnet-bot test Windows_NT x64 Build and Test
@dotnet-bot test Windows_NT x64 Checked corefx_baseline
@dotnet-bot test Windows_NT x64 Checked r2r
@dotnet-bot test Windows_NT x86 Checked Build and Test
@dotnet-bot test Windows_NT x86 Checked corefx_baseline
@dotnet-bot test Windows_NT x86 Checked r2r
@dotnet-bot test Windows_NT arm Cross Checked normal Build and Test
@dotnet-bot test Windows_NT arm64 Cross Checked normal Build and Test

@BruceForstall
Clean up build.cmd/build-test.cmd/runtest.cmd
a248d79 
Various minor cleanups:
1. Use the same naming/style for all three.
2. Make the style consistent throughout each. E.g., consistent indents,
   capitalization.
3. Add more consistent output, including the prefix tag used everywhere.
4. build.cmd: only build cross components if native build is enabled.
5. Use new __Logging variable to consolidate all logging arguments,
   to reduce large (unexpanded) command line lengths.
@BruceForstall
Copy link
Author

@dotnet-bot test Windows_NT x64 Build and Test
@dotnet-bot test Windows_NT x64 Checked corefx_baseline
@dotnet-bot test Windows_NT x64 Checked r2r
@dotnet-bot test Windows_NT x86 Checked Build and Test
@dotnet-bot test Windows_NT x86 Checked corefx_baseline
@dotnet-bot test Windows_NT x86 Checked r2r
@dotnet-bot test Windows_NT arm Cross Checked normal Build and Test
@dotnet-bot test Windows_NT arm64 Cross Checked normal Build and Test

@BruceForstall
Copy link
Author

@dotnet-bot test Windows_NT x64 Release r2r
@dotnet-bot test Windows_NT x86 Release r2r
@dotnet-bot test Windows_NT arm Cross Release normal Build and Test
@dotnet-bot test Windows_NT arm64 Cross Release normal Build and Test
@dotnet-bot test Ubuntu arm Cross Release normal Build and Test

@BruceForstall
Copy link
Author

@dotnet-bot test Windows_NT x64 Release r2r
@dotnet-bot test Windows_NT x86 Release r2r
@dotnet-bot test Windows_NT x64 Checked r2r
@dotnet-bot test Windows_NT x86 Checked r2r

@dotnet-bot test Windows_NT x86 Checked corefx_baseline

@BruceForstall
Copy link
Author

@dotnet-bot test Windows_NT x64 Release r2r

@BruceForstall
Copy link
Author

@jashook Any chance I could get you to review this?

@BruceForstall BruceForstall merged commit b37c6d8 into dotnet:master Aug 7, 2018
@BruceForstall BruceForstall deleted the CleanUpBuildCmd branch August 7, 2018 19:35
@BruceForstall BruceForstall mentioned this pull request Aug 8, 2018
Merged
echesakov added a commit that referenced this pull request Oct 24, 2018
@echesakov
[release/2.2] Remove the Smarty dependency and move Windows ARM to He…
01f7c9b 
…lix queue

Port (partially) the following changes:

*  Build xunit wrappers the same way on windows and unix (#18695)
*  Update vc-runtime package to support ARM and ARM64 with current builds (#19265)
*  build-test - fix TestWrapper CS warnings (#19180)
*  Clean up build.cmd/build-test.cmd/runtest.cmd (#19291)
*  Use runtest.py to run tests for all platforms (#19213)
*  Updating runtest.py so that it works with Python 3 (#19768)
*  Fix build-test.sh wrapper build (#19779)
*  Move ARM64 Windows boxen to be Helix-provisioned (#20204)
*  Runtest.py on Windows Arm(64) (#20227)
*  Use runtest.cmd for arm(64) windows testing (#20301)
*  Do not restore or initialize buildtools for x86/arm64 (#20370)
*  Add hack for arm64/x86 to skip build tools restore (#20390)

Update Xunit to 2.4.1 prerelease version

Use the latest version (dbf0bf1) of tests/runtest.py
echesakov added a commit that referenced this pull request Oct 24, 2018
@echesakov
[release/2.2] Remove the Smarty dependency and move Windows ARM to He…
4f4f0e9 
…lix queue

Port (partially) the following changes:

*  Build xunit wrappers the same way on windows and unix (#18695)
*  Work around cmd command length limit in xunit Exec task (#19095)
*  Update vc-runtime package to support ARM and ARM64 with current builds (#19265)
*  build-test - fix TestWrapper CS warnings (#19180)
*  Clean up build.cmd/build-test.cmd/runtest.cmd (#19291)
*  Use runtest.py to run tests for all platforms (#19213)
*  Updating runtest.py so that it works with Python 3 (#19768)
*  Fix build-test.sh wrapper build (#19779)
*  Move ARM64 Windows boxen to be Helix-provisioned (#20204)
*  Runtest.py on Windows Arm(64) (#20227)
*  Use runtest.cmd for arm(64) windows testing (#20301)
*  Do not restore or initialize buildtools for x86/arm64 (#20370)
*  Add hack for arm64/x86 to skip build tools restore (#20390)

Update Xunit to 2.4.1 prerelease version

Use the latest version (dbf0bf1) of tests/runtest.py
echesakov added a commit that referenced this pull request Oct 25, 2018
@echesakov
[release/2.2] Remove the Smarty dependency and move Windows ARM to He…
326056d 
…lix queue

Port (partially) the following changes:

*  Build xunit wrappers the same way on windows and unix (#18695)
*  Work around cmd command length limit in xunit Exec task (#19095)
*  Update vc-runtime package to support ARM and ARM64 with current builds (#19265)
*  build-test - fix TestWrapper CS warnings (#19180)
*  Clean up build.cmd/build-test.cmd/runtest.cmd (#19291)
*  Use runtest.py to run tests for all platforms (#19213)
*  Updating runtest.py so that it works with Python 3 (#19768)
*  Fix build-test.sh wrapper build (#19779)
*  Move ARM64 Windows boxen to be Helix-provisioned (#20204)
*  Runtest.py on Windows Arm(64) (#20227)
*  Use runtest.cmd for arm(64) windows testing (#20301)
*  Do not restore or initialize buildtools for x86/arm64 (#20370)
*  Add hack for arm64/x86 to skip build tools restore (#20390)

Update Xunit to 2.4.1 prerelease version

Use the latest version (dbf0bf1) of tests/runtest.py
@echesakov echesakov mentioned this pull request Oct 25, 2018
Merged
echesakov added a commit that referenced this pull request Oct 26, 2018
@echesakov
[release/2.2] Remove the Smarty dependency and move Windows ARM to He…
430b0d8 
…lix queue

Port (partially) the following changes:

*  Build xunit wrappers the same way on windows and unix (#18695)
*  Work around cmd command length limit in xunit Exec task (#19095)
*  Update vc-runtime package to support ARM and ARM64 with current builds (#19265)
*  build-test - fix TestWrapper CS warnings (#19180)
*  Clean up build.cmd/build-test.cmd/runtest.cmd (#19291)
*  Use runtest.py to run tests for all platforms (#19213)
*  Updating runtest.py so that it works with Python 3 (#19768)
*  Fix build-test.sh wrapper build (#19779)
*  Move ARM64 Windows boxen to be Helix-provisioned (#20204)
*  Runtest.py on Windows Arm(64) (#20227)
*  Use runtest.cmd for arm(64) windows testing (#20301)
*  Do not restore or initialize buildtools for x86/arm64 (#20370)
*  Add hack for arm64/x86 to skip build tools restore (#20390)

Update Xunit to 2.4.1 prerelease version

Use the latest version (dbf0bf1) of tests/runtest.py
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jashook jashook jashook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BruceForstall @jashook