Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

[WIP] Update vc-runtime package to support ARM and ARM64 with current… #19265

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dependencies.props
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
<XunitPerformanceApiPackageVersion>1.0.0-beta-build0015</XunitPerformanceApiPackageVersion>
<MicrosoftDiagnosticsTracingTraceEventPackageVersion>2.0.4</MicrosoftDiagnosticsTracingTraceEventPackageVersion>
<CommandLineParserVersion>2.2.0</CommandLineParserVersion>
<VCRuntimeVersion>1.2.0</VCRuntimeVersion>
<VCRuntimeVersion>2.0.0</VCRuntimeVersion>

<!-- Scenario tests install this version of Microsoft.NetCore.App, then patch coreclr binaries via xcopy. At the moment it is
updated manually whenever breaking changes require it to move forward, but it would be nice if we could update it automatically
Expand Down
6 changes: 0 additions & 6 deletions netci.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -3227,12 +3227,6 @@ def static CreateWindowsArmTestJob(def dslFactory, def project, def architecture
def archLocation = testListArch[architecture]

addCommand("copy %WORKSPACE%\\tests\\${archLocation}\\Tests.lst bin\\tests\\${osGroup}.${architecture}.${configuration}")

if (architecture == "arm64") {
addCommand("copy C:\\Jenkins\\vcruntime140.dll bin\\tests\\${osGroup}.${architecture}.${configuration}\\Tests\\Core_Root")
addCommand("copy C:\\Jenkins\\vcruntime140d.dll bin\\tests\\${osGroup}.${architecture}.${configuration}\\Tests\\Core_Root")
}

addCommand("pushd bin\\tests\\${osGroup}.${architecture}.${configuration}")
addCommand("${smartyCommand}")

Expand Down
2 changes: 1 addition & 1 deletion tests/arm/Tests.lst
Original file line number Diff line number Diff line change
Expand Up @@ -10417,7 +10417,7 @@ RelativePath=Exceptions\ForeignThread\ForeignThreadExceptions\ForeignThreadExcep
WorkingDir=Exceptions\ForeignThread\ForeignThreadExceptions
Expected=0
MaxAllowedDurationSeconds=600
Categories=EXPECTED_FAIL;12898
Categories=EXPECTED_PASS
HostStyle=0

[box-unbox-generics013.cmd_1310]
Expand Down
2 changes: 1 addition & 1 deletion tests/arm64/Tests.lst
Original file line number Diff line number Diff line change
Expand Up @@ -89585,7 +89585,7 @@ RelativePath=Exceptions\ForeignThread\ForeignThreadExceptions\ForeignThreadExcep
WorkingDir=Exceptions\ForeignThread\ForeignThreadExceptions
Expected=0
MaxAllowedDurationSeconds=600
Categories=EXPECTED_FAIL;10636;NEW
Categories=EXPECTED_PASS;NEW
HostStyle=0

[MathFExp.cmd_11575]
Expand Down
2 changes: 1 addition & 1 deletion tests/build.proj
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<RestoreProjects Include="$(MSBuildThisFileDirectory)src\Common\targeting_pack_ref\targeting_pack_ref.csproj" />
<RestoreProjects Include="$(MSBuildThisFileDirectory)src\Common\test_dependencies\test_dependencies.csproj" />
<RestoreProjects Include="$(MSBuildThisFileDirectory)src\Common\test_runtime\test_runtime.csproj" />
<RestoreProjects Include="$(MSBuildThisFileDirectory)src\Common\vc_runtime\vc_runtime.csproj" Condition="'$(__BuildArch)' == 'arm'"/>
<RestoreProjects Include="$(MSBuildThisFileDirectory)src\Common\vc_runtime\vc_runtime.csproj" Condition="'$(__BuildArch)' == 'arm' or '$(__BuildArch)' == 'arm64'"/>
<RestoreProjects Include="$(MSBuildThisFileDirectory)src\JIT\config\benchmark+roslyn\benchmark+roslyn.csproj" />
<RestoreProjects Include="$(MSBuildThisFileDirectory)src\JIT\config\benchmark+serialize\benchmark+serialize.csproj" />
<RestoreProjects Include="$(MSBuildThisFileDirectory)src\JIT\config\benchmark\benchmark.csproj" />
Expand Down
4 changes: 2 additions & 2 deletions tests/publishdependency.targets
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@

<ItemGroup>
<CrossGenFiles Include="..\packages\runtime.$(TargetRid).Microsoft.NETCore.Runtime.CoreCLR\$(DesiredPackageVersionArg)\tools\crossgen*"/>
<VCRuntimeFiles Include="..\packages\vc-runtime\$(VCRuntimeVersion)\lib\netcoreapp1.1\*.dll"/>
<VCRuntimeFiles Include="..\packages\vc-runtime\$(VCRuntimeVersion)\content\VC\Redist\MSVC\14.14.26405\onecore\$(BuildArch)\Microsoft.VC141.CRT\*"/>
</ItemGroup>

<PropertyGroup>
Expand Down Expand Up @@ -162,7 +162,7 @@
<Target Name="CopyVCRuntimeToCoreRoot"
AfterTargets="CopyDependecyToCoreRoot"
Outputs="$(CORE_ROOT)\*.*"
Condition="'$(BuildArch)' == 'arm'">
Condition="'$(BuildArch)' == 'arm' or '$(BuildArch)' == 'arm64'">

<Copy
SourceFiles="@(VCRuntimeFiles)"
Expand Down
8 changes: 4 additions & 4 deletions tests/src/Common/vc_runtime/vc_runtime.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
<Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
<CLRTestKind>BuildOnly</CLRTestKind>
<NugetTargetMoniker>.NETCoreApp,Version=v1.1</NugetTargetMoniker>
<NugetTargetMonikerShort>netcoreapp1.1</NugetTargetMonikerShort>
<NugetTargetMoniker>.NETCoreApp,Version=v3.0</NugetTargetMoniker>
<NugetTargetMonikerShort>netcoreapp3.0</NugetTargetMonikerShort>
<IsTestProject>false</IsTestProject>
</PropertyGroup>
<ItemGroup>
Expand All @@ -15,10 +15,10 @@
</PackageReference>
</ItemGroup>
<PropertyGroup>
<TargetFramework>netcoreapp1.1</TargetFramework>
<TargetFramework>netcoreapp3.0</TargetFramework>
<TargetFrameworkIdentifier>.NETCoreApp</TargetFrameworkIdentifier>
<PackageTargetFallback>$(PackageTargetFallback);dnxcore50;netcoreapp1.1;portable-net45+win8</PackageTargetFallback>
<RuntimeIdentifiers>win-arm</RuntimeIdentifiers>
<RuntimeIdentifiers>win-arm;win-arm64</RuntimeIdentifiers>
<ContainsPackageReferences>true</ContainsPackageReferences>
<PrereleaseResolveNuGetPackages>false</PrereleaseResolveNuGetPackages>
</PropertyGroup>
Expand Down