Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Fix compiler warnings in test wrapper generation #19172

Closed
wants to merge 1 commit into from
Closed

Fix compiler warnings in test wrapper generation #19172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/runtest.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ namespace $([System.String]::Copy($(Category)).Replace(".","_").Replace("\","").
{
sErrorText = System.IO.File.ReadAllText(errorFile)%3B
}
catch(Exception ex)
catch(Exception)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feedback on #19109 was to print the exception details here. #19109 (comment)

CC. @AaronRobinsonMSFT

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please print the exception itself. It costs very little but offers so much when reading the logs. Thanks @tannergooding !

{
sErrorText = "Unable to read error file: " + errorFile%3B
}
Expand All @@ -268,7 +268,7 @@ namespace $([System.String]::Copy($(Category)).Replace(".","_").Replace("\","").
outputText = outputReader.ReadToEnd()%3B
outputReader.Close()%3B
}
catch(Exception ex)
catch(Exception)
{
outputText = "Unable to read output file: " + outputFile%3B
}
Expand Down