Replacing usages of random with TestLibrary.Generator in the HWIntrinsic templated tests

[tannergooding]

FYI. @CarolEidt, @fiigii, @echesakovMSFT

[tannergooding]

Tried to break this up into logical commits. There are still some usages of random, in the non-templated tests. I am working on moving those to be templated.

[CarolEidt]

Tried to break this up into logical commits. There are still some usages of random, in the non-templated tests. I am working on moving those to be templated.

Thanks! that makes it much easier to review.

[CarolEidt]

LGTM

[tannergooding]

The JitStress failures look to all be the same and are all occurring outside this PR.

Going to briefly investigate to see if I can find the issue.

[tannergooding]

Rebased onto head of master, as I can't repro the JitStress failures locally.

[tannergooding]

JitStress jobs are failing because of #18695. I have logged https://github.com/dotnet/coreclr/issues/19075 to track.

Wasn't reproing locally, initially, as it requires you to build with -priority=1

[tannergooding]

@dotnet-bot test Windows_NT x64 Checked jitincompletehwintrinsic
@dotnet-bot test Windows_NT x64 Checked jitx86hwintrinsicnoavx
@dotnet-bot test Windows_NT x64 Checked jitx86hwintrinsicnoavx2
@dotnet-bot test Windows_NT x64 Checked jitx86hwintrinsicnosimd
@dotnet-bot test Windows_NT x64 Checked jitnox86hwintrinsic

@dotnet-bot test Windows_NT x86 Checked jitincompletehwintrinsic
@dotnet-bot test Windows_NT x86 Checked jitx86hwintrinsicnoavx
@dotnet-bot test Windows_NT x86 Checked jitx86hwintrinsicnoavx2
@dotnet-bot test Windows_NT x86 Checked jitx86hwintrinsicnosimd
@dotnet-bot test Windows_NT x86 Checked jitnox86hwintrinsic

@dotnet-bot test Ubuntu x64 Checked jitincompletehwintrinsic
@dotnet-bot test Ubuntu x64 Checked jitx86hwintrinsicnoavx
@dotnet-bot test Ubuntu x64 Checked jitx86hwintrinsicnoavx2
@dotnet-bot test Ubuntu x64 Checked jitx86hwintrinsicnosimd
@dotnet-bot test Ubuntu x64 Checked jitnox86hwintrinsic

[tannergooding]

Rebased onto dotnet/master now that the JitStress issue has been resolved.