Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Update CoreFX CI packages to NetcoreApp3 #18760

Merged
merged 3 commits into from
Jul 3, 2018
Merged

Conversation

A-And
Copy link

@A-And A-And commented Jul 2, 2018

Updates restored packages.
@jkotas mentioned some failures we're seeing are due to CoreFX mismatch - setting TargetFramework before specifying dependencies restored netstandard versions of libraries. Moving TargetFramework up seems to have fixed the issue.

@A-And A-And changed the title Update to FX CI packages to NetcoreApp3 Update CoreFX CI packages to NetcoreApp3 Jul 2, 2018
@A-And A-And mentioned this pull request Jul 2, 2018
@A-And
Copy link
Author

A-And commented Jul 3, 2018

@dotnet-bot test this please

@A-And
Copy link
Author

A-And commented Jul 3, 2018

A substantial amount of failures were fixed because of this change.
@jkotas @RussKeldorph - does the current exclusion list look reasonable to you?

@jkotas
Copy link
Member

jkotas commented Jul 3, 2018

Yes, it looks a lot better.

@jkotas jkotas merged commit f32c75e into dotnet:master Jul 3, 2018
@A-And A-And deleted the NuGetRIDTesthost branch July 3, 2018 05:15
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
* Update to FX CI packages to NetcoreApp3

* Add Extra Dependencies

* Enable all tests fixed by change


Commit migrated from dotnet/coreclr@f32c75e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants