Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Fix & test for #18362 #18696

Merged
merged 2 commits into from
Jun 29, 2018
Merged

Fix & test for #18362 #18696

merged 2 commits into from
Jun 29, 2018

Conversation

CarolEidt
Copy link

Also add to the arm & arm64 tests.lst

Also add to the arm & arm64 tests.lst
Need to build a use for each reg.
Also, dump the defList if it's not empty at end of block.
@CarolEidt
Copy link
Author

CarolEidt commented Jun 28, 2018

The first commit is the test; it fails as expected on arm (it doesn't fail with the altjit).

@CarolEidt CarolEidt changed the title Add test for #18362 Fix & test for #18362 Jun 29, 2018
@CarolEidt
Copy link
Author

The problem was that LSRA was creating only a singe use for multi-reg ops under FIELD_LIST. We need to build a use for each reg.
Also, dump the defList if it's not empty at end of block, to make it easier to track down the cause of this assert in future.

@CarolEidt
Copy link
Author

@dotnet/jit-contrib PTAL

@BruceForstall
Copy link

Link: #18362

@CarolEidt
Copy link
Author

Fix #18362

@CarolEidt
Copy link
Author

@BruceForstall @jashook the reason this didn't repro with the altjit is that getTailCallCopyArgsThunk returns null, so it doesn't do the tail copy (which leads to the split args case that this bug needs to repro). Do you think it's worth making it return a dummy value for the altjit?

@CarolEidt CarolEidt merged commit 13e7606 into dotnet:master Jun 29, 2018
@CarolEidt CarolEidt deleted the Fix18362 branch June 29, 2018 16:41
@jashook
Copy link

jashook commented Jun 29, 2018

I will let Bruce comment further; however, adding in altjit specific return values to me sounds dangerous.

@BruceForstall
Copy link

@CarolEidt I think we should make it work for altjit as you suggest. Wrap getTailCallCopyArgsThunk as eeGetTailCallCopyArgsThunk in ee_il_dll.cpp, then #ifdef on ARM and AMD64 under !info.compMatchedVM to return something dummy, to match the VM CEEInfo::getTailCallCopyArgsThunk conditions.

picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Fix & test for dotnet/coreclr#18362

Commit migrated from dotnet/coreclr@13e7606
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants